Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update verdepcheck action strategies #971

Closed
wants to merge 1 commit into from
Closed

Conversation

pawelru
Copy link
Contributor

@pawelru pawelru commented Nov 22, 2023

probably an oversight

@pawelru pawelru added the core label Nov 22, 2023
@pawelru pawelru requested a review from averissimo November 22, 2023 13:44
@pawelru pawelru enabled auto-merge (squash) November 22, 2023 13:44
Copy link
Contributor

badge

Code Coverage Summary

Filename                         Stmts    Miss  Cover    Missing
-----------------------------  -------  ------  -------  -------------------------------------------------------------------------------------------------------------------------------
R/dummy_functions.R                 92      50  45.65%   9-71
R/get_rcode_utils.R                 38       1  97.37%   50
R/include_css_js.R                  24       0  100.00%
R/init.R                            79      25  68.35%   139, 164-185, 217-219, 221-223, 225-226
R/landing_popup_module.R            25      25  0.00%    61-87
R/module_filter_manager.R          107      29  72.90%   62-70, 79-84, 228, 233-246
R/module_nested_tabs.R             174      14  91.95%   72, 119, 138-145, 163, 216, 238, 271
R/module_snapshot_manager.R        209     157  24.88%   87-99, 127-136, 140-152, 154-161, 168-182, 186-188, 190-195, 198-208, 211-227, 236-251, 265-288, 291-302, 305-311, 325, 346-369
R/module_tabs_with_filters.R        73       2  97.26%   95, 140
R/module_teal_with_splash.R        120      11  90.83%   73, 87-95, 122
R/module_teal.R                    141       8  94.33%   68, 71, 158-159, 165, 196, 204-205
R/modules_debugging.R               18      18  0.00%    25-44
R/modules.R                        143      26  81.82%   119, 132, 226-229, 243-248, 259-263, 378-421
R/reporter_previewer_module.R       18       2  88.89%   26, 30
R/show_rcode_modal.R                20      20  0.00%    16-37
R/tdata.R                           39       1  97.44%   158
R/teal_data_module.R                 6       0  100.00%
R/teal_reporter.R                   60       5  91.67%   65, 116-117, 120, 137
R/teal_slices-store.R               25       0  100.00%
R/teal_slices.R                     59      12  79.66%   135-148
R/utils.R                          108      27  75.00%   113-140
R/validate_inputs.R                 32       0  100.00%
R/validations.R                     58      37  36.21%   109-371
R/zzz.R                             11       7  36.36%   3-14
TOTAL                             1679     477  71.59%

Diff against main

Filename      Stmts    Miss  Cover
----------  -------  ------  --------
TOTAL             0       0  +100.00%

Results for commit: ffbd196

Minimum allowed coverage is 80%

♻️ This comment has been updated with latest results

Copy link
Contributor

Unit Tests Summary

    1 files    18 suites   12s ⏱️
195 tests 195 ✔️ 0 💤 0
367 runs  367 ✔️ 0 💤 0

Results for commit ffbd196.

@averissimo
Copy link
Contributor

Duplicate of #912

That one was still failing due to problems installing dependencies (teal.code not being released)

Should we just merge that one and keep an eye that it succeeds when teal.code and teal.data are released?

@pawelru
Copy link
Contributor Author

pawelru commented Nov 22, 2023

Duplicate of #912

That one was still failing due to problems installing dependencies (teal.code not being released)

Should we just merge that one and keep an eye that it succeeds when teal.code and teal.data are released?

Yes. Let's do that. Just approved it

@pawelru pawelru closed this Nov 22, 2023
auto-merge was automatically disabled November 22, 2023 15:13

Pull request was closed

@pawelru pawelru deleted the pawelru-patch-1 branch November 22, 2023 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants