Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove arguments #630

Merged
merged 6 commits into from
Nov 14, 2024
Merged

Remove arguments #630

merged 6 commits into from
Nov 14, 2024

Conversation

llrs-roche
Copy link
Contributor

@llrs-roche llrs-roche commented Nov 8, 2024

Pull Request

Fixes #623

After 1 year with an error and with verify() in place, it makes sense to remove them.
I didn't keep any documentation or redirect users to other functions/examples, (but it is hard for me to guess if users might not know how to update their code).

The checks will fail due to #629

Copy link
Contributor

github-actions bot commented Nov 8, 2024

✅ All contributors have signed the CLA
Posted by the CLA Assistant Lite bot.

@llrs-roche
Copy link
Contributor Author

I have read the CLA Document and I hereby sign the CLA

Copy link
Contributor

github-actions bot commented Nov 8, 2024

Unit Tests Summary

  1 files   29 suites   24s ⏱️
367 tests 367 ✅ 0 💤 0 ❌
819 runs  819 ✅ 0 💤 0 ❌

Results for commit 72e414e.

♻️ This comment has been updated with latest results.

Copy link
Contributor

github-actions bot commented Nov 8, 2024

badge

Code Coverage Summary

Filename                        Stmts    Miss  Cover    Missing
----------------------------  -------  ------  -------  -----------------------------------------------------------------------------------------------------------------------
R/calls_combine_by.R                7       0  100.00%
R/choices_labeled.R                49      14  71.43%   25, 36, 41, 51-56, 68, 72-76
R/count_labels.R                  102       0  100.00%
R/filter_panel_api.R               27       1  96.30%   132
R/FilteredData-utils.R             58      17  70.69%   38-43, 139, 161-170
R/FilteredData.R                  539     186  65.49%   110, 184, 323, 395, 500-508, 531, 550-593, 613-616, 657, 694, 715-747, 770-772, 775-789, 793-803, 806-849, 906, 918-940
R/FilteredDataset-utils.R          23       1  95.65%   125
R/FilteredDataset.R               232      72  68.97%   48, 147, 179, 206-276, 379
R/FilteredDatasetDataframe.R      120       8  93.33%   87, 148, 158, 233-237
R/FilteredDatasetDefault.R         18       4  77.78%   104-117
R/FilteredDatasetMAE.R            133      37  72.18%   56, 117-122, 159-164, 168-169, 187-209
R/FilterPanelAPI.R                 10       0  100.00%
R/FilterState-utils.R             101       2  98.02%   264, 294
R/FilterState.R                   363      61  83.20%   89, 213, 231-235, 242-243, 257-258, 264-265, 321, 323, 325, 377, 420, 641, 684-707, 717-736, 771-777, 786-792
R/FilterStateChoices.R            352     109  69.03%   301, 368-375, 379-396, 423-426, 439-450, 462-470, 474-503, 523-526, 529-532, 542-567, 578, 583, 594
R/FilterStateDate.R               213     127  40.38%   230, 282-437
R/FilterStateDatettime.R          307     197  35.83%   266, 318-547
R/FilterStateEmpty.R               53      31  41.51%   89, 99-104, 117, 129-169
R/FilterStateExpr.R                83      68  18.07%   167-280
R/FilterStateLogical.R            194     142  26.80%   136, 158, 218, 222-404
R/FilterStateRange.R              410     104  74.63%   262, 384, 517-521, 524-534, 537, 548-554, 565-577, 581-591, 595-597, 610-636, 651, 654, 668-685, 720-725, 735-737
R/FilterStates-utils.R             70       7  90.00%   108, 127, 188-194
R/FilterStates.R                  370      32  91.35%   63, 80-84, 196, 318-327, 412-415, 458, 496, 559-563, 608, 728-731
R/FilterStatesDF.R                  5       0  100.00%
R/FilterStatesMAE.R                10       1  90.00%   40
R/FilterStatesMatrix.R              7       0  100.00%
R/FilterStatesSE.R                218      62  71.56%   36, 73-75, 85-87, 110-117, 125-132, 208, 233, 252-270, 278-296, 304
R/include_css_js.R                  5       5  0.00%    12-16
R/teal_slice.R                    107       4  96.26%   131, 195-196, 206
R/teal_slices.R                    84       5  94.05%   150-155
R/test_utils.R                     21       0  100.00%
R/utils.R                          24       0  100.00%
R/variable_types.R                 15       1  93.33%   48
R/zzz.R                            17      17  0.00%    3-47
TOTAL                            4347    1315  69.75%

Diff against main

Filename                  Stmts    Miss  Cover
----------------------  -------  ------  -------
R/FilteredData-utils.R      -10      -8  +7.45%
TOTAL                       -10      -8  +0.11%

Results for commit: 72e414e

Minimum allowed coverage is 80%

♻️ This comment has been updated with latest results

@m7pr m7pr self-assigned this Nov 12, 2024
Copy link
Contributor

@gogonzo gogonzo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@llrs-roche this needs a NEWS entry

NEWS.md Outdated Show resolved Hide resolved
@m7pr
Copy link
Contributor

m7pr commented Nov 13, 2024

Hey, I left a comment in the main issue #623 (comment)

.github/workflows/check.yaml Outdated Show resolved Hide resolved
.github/workflows/check.yaml Outdated Show resolved Hide resolved
Copy link
Contributor

@m7pr m7pr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@llrs-roche left you two comments, once they are accepted (the ones about workflows) you are free to merge

llrs-roche and others added 2 commits November 14, 2024 16:10
Co-authored-by: Marcin <[email protected]>
Signed-off-by: Lluís Revilla <[email protected]>
Co-authored-by: Marcin <[email protected]>
Signed-off-by: Lluís Revilla <[email protected]>
@llrs-roche llrs-roche enabled auto-merge (squash) November 14, 2024 15:11
@llrs-roche llrs-roche merged commit 2c60f56 into main Nov 14, 2024
28 checks passed
@llrs-roche llrs-roche deleted the 623_deprecate_args@main branch November 14, 2024 15:15
@github-actions github-actions bot locked and limited conversation to collaborators Nov 14, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Review Deprecated Functions
4 participants