Skip to content

Commit

Permalink
Remove arguments (#630)
Browse files Browse the repository at this point in the history
# Pull Request

Fixes #623 

After 1 year with an error and with `verify()` in place, it makes sense
to remove them.
I didn't keep any documentation or redirect users to other
functions/examples, (but it is hard for me to guess if users might not
know how to update their code).

The checks will fail due to #629

---------

Signed-off-by: Lluís Revilla <[email protected]>
Co-authored-by: Marcin <[email protected]>
  • Loading branch information
llrs-roche and m7pr authored Nov 14, 2024
1 parent a3d9a0f commit 2c60f56
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 20 deletions.
1 change: 1 addition & 0 deletions NEWS.md
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
### Enhancements

* Reduced the space of the filter panel by not displaying the "add filters" UI in a separate panel.
* The deprecated parameters `code` and `check` were removed from `init_filtered_data()`.

### Bug fixes

Expand Down
16 changes: 1 addition & 15 deletions R/FilteredData-utils.R
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,6 @@
#'
#' @param x (`named list`) of datasets.
#' @param join_keys (`join_keys`) see [`teal.data::join_keys()`].
#' @param code `r lifecycle::badge("deprecated")`
#' @param check `r lifecycle::badge("deprecated")`
#'
#' @return Object of class `FilteredData`.
#'
Expand All @@ -14,21 +12,9 @@
#' datasets
#'
#' @export
init_filtered_data <- function(x, join_keys = teal.data::join_keys(), code, check) { # nolint
init_filtered_data <- function(x, join_keys = teal.data::join_keys()) { # nolint
checkmate::assert_list(x, any.missing = FALSE, names = "unique")
checkmate::assert_class(join_keys, "join_keys")
if (!missing(code)) {
lifecycle::deprecate_stop(
"0.5.0",
"init_filtered_data(code = 'No longer supported')"
)
}
if (!missing(check)) {
lifecycle::deprecate_stop(
"0.5.0",
"init_filtered_data(check = 'No longer supported')"
)
}
FilteredData$new(x, join_keys = join_keys)
}

Expand Down
6 changes: 1 addition & 5 deletions man/init_filtered_data.Rd

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

0 comments on commit 2c60f56

Please sign in to comment.