Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove arguments #630

Merged
merged 6 commits into from
Nov 14, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions NEWS.md
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
### Enhancements

* Reduced the space of the filter panel by not displaying the "add filters" UI in a separate panel.
* The deprecated parameters `code` and `check` were removed from `init_filtered_data()`.

### Bug fixes

Expand Down
16 changes: 1 addition & 15 deletions R/FilteredData-utils.R
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,6 @@
#'
#' @param x (`named list`) of datasets.
#' @param join_keys (`join_keys`) see [`teal.data::join_keys()`].
#' @param code `r lifecycle::badge("deprecated")`
#' @param check `r lifecycle::badge("deprecated")`
#'
#' @return Object of class `FilteredData`.
#'
Expand All @@ -14,21 +12,9 @@
#' datasets
#'
#' @export
init_filtered_data <- function(x, join_keys = teal.data::join_keys(), code, check) { # nolint
init_filtered_data <- function(x, join_keys = teal.data::join_keys()) { # nolint
checkmate::assert_list(x, any.missing = FALSE, names = "unique")
checkmate::assert_class(join_keys, "join_keys")
if (!missing(code)) {
lifecycle::deprecate_stop(
"0.5.0",
"init_filtered_data(code = 'No longer supported')"
)
}
if (!missing(check)) {
lifecycle::deprecate_stop(
"0.5.0",
"init_filtered_data(check = 'No longer supported')"
)
}
FilteredData$new(x, join_keys = join_keys)
}

Expand Down
6 changes: 1 addition & 5 deletions man/init_filtered_data.Rd

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading