Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Editable Card names #94

Closed
Tracked by #68
Polkas opened this issue Jun 29, 2022 · 6 comments · Fixed by #172
Closed
Tracked by #68

Editable Card names #94

Polkas opened this issue Jun 29, 2022 · 6 comments · Fixed by #172
Assignees
@mhallal1
Labels
core

Comments

@Polkas
Copy link
Contributor

Polkas commented Jun 29, 2022 •
edited
Loading

When we get the Add Card Modal we should add there a Card Name field additionally to already asked comment.
This Title will be used only for the Preview purposes or should we use it for the Card title (Block) too?
This will help to distinguish many cards from the same module , now they could easily have the same name in the previewer.
@Polkas Polkas added the core label Jun 29, 2022
@Polkas Polkas mentioned this issue Jun 29, 2022
Merged
5 tasks
@nikolas-burkoff nikolas-burkoff mentioned this issue Jul 5, 2022
Merged
@Polkas Polkas mentioned this issue Jul 6, 2022
Closed
3 tasks
@gogonzo
Copy link
Contributor

gogonzo commented Jul 21, 2022

Beware these names should be reproducible from archiver.

@nikolas-burkoff nikolas-burkoff mentioned this issue Oct 6, 2022
Closed
@nikolas-burkoff
Copy link
Contributor

Also from insightsengineering/teal.modules.hermes#284 (comment) - could the default name be the name of the label of the module

@danielinteractive
Copy link
Contributor

thanks @nikolas-burkoff for linking this here. I think that would be ideal if it can work with the teal reporter framework.

@kumamiao kumamiao mentioned this issue Oct 6, 2022
Closed
12 tasks
@mhallal1 mhallal1 self-assigned this Nov 21, 2022
@Polkas
Copy link
Contributor Author

Polkas commented Nov 21, 2022

linked to :#35

This was referenced Nov 22, 2022
Merged
Closed
@lcd2yyz
Copy link

lcd2yyz commented Nov 22, 2022

Linking to #150
Make sense to use module label for card name as default, but allowing card name to be editable.

@mhallal1
Copy link
Contributor

@lcd2yyz @danielinteractive we decided with @nikolas-burkoff and @Polkas that we will not pass the module label to the reporter cards before teal refactor is accomplished. label argument will have to be passed from tm_g_XXX to srv_g_xxx of all modules using reporter to accomplish this task.
Therefore, the decision right now is to keep the static assignment of the name to cards and add the option to modify the card name using UI pop up, please refer to the under development PR: #172

mhallal1 added a commit that referenced this issue Nov 25, 2022
@mhallal1 @github-actions @Polkas
edit card name (#172)
6683d90 
closes #94 

After discussion with team members @nikolas-burkoff and @Polkas, we
decided the following:
1. the module developer can set a default card label in the card
function (it can be unnamed also)
2. the module user can change the card label with the UI input
3. No support for passing the module name by default to the reporter
cards till the teal refactor is accomplished as it requires passing the
label argument to the server function of all modules.

Signed-off-by: Mahmoud Hallal <[email protected]>
Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Maciej Nasinski <[email protected]>
@donyunardi donyunardi mentioned this issue Feb 15, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mhallal1 mhallal1

Labels
core
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

edit card name insightsengineering/teal.reporter
6 participants
@danielinteractive @gogonzo @Polkas @nikolas-burkoff @lcd2yyz @mhallal1