-
-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
edit card name #172
edit card name #172
Conversation
…o 94_editable_card_names@main
shiny::textInput( | ||
ns("label"), | ||
"Card Name", | ||
value = "", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It feels like the modules should be able to give a default to here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this requires passing label
as an argument to add_card_button_srv
and simple_reporter_srv
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Now I think it could be a good move as we are not hiding some value internally. The label argument can by "" by default.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Another way can be to not have any default for label then to have empty name if not specified.when card is added.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yup that's definitely a better way of adding it - though we'd still need to pass the label into the module args - might be best to not do that right now though and wait until teal is reconfigured to make that not needed...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Another way can be to not have any default for label then to have empty name if not specified.when card is added.
Or to have the name the module developer has set for it (rather than the app developer).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
so the latest update is:
- the module developer can set a default card label in the card function (it can be unnamed also)
- the module user can change the card label with the UI input
- No support for passing the module name by default to the reporter cards till the teal refactor is accomplished as it requires passing the label argument to the server function of all modules.
Code Coverage Summary
Diff against main
Results for commit: a95d7ff Minimum allowed coverage is ♻️ This comment has been updated with latest results |
Co-authored-by: Maciej Nasinski <[email protected]> Signed-off-by: Mahmoud Hallal <[email protected]>
…o 94_editable_card_names@main
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
closes #94
After discussion with team members @nikolas-burkoff and @Polkas, we decided the following: