Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[UAT] Test teal.reporter in modules #284

Closed
donyunardi opened this issue Sep 30, 2022 · 3 comments · Fixed by #285
Closed

[UAT] Test teal.reporter in modules #284

donyunardi opened this issue Sep 30, 2022 · 3 comments · Fixed by #285
Assignees
Labels

Comments

@donyunardi
Copy link
Contributor

No description provided.

@danielinteractive
Copy link
Collaborator

danielinteractive commented Oct 5, 2022

Observations from my UAT:

@danielinteractive
Copy link
Collaborator

General comment on the reporter titles: would it be possible to have the title not hardcoded within each module but taking whatever the module is called in the app? I think that would help a lot 1) to keep the code maintainable and 2) to make it easier for the user to understand which reporter output belongs to which tab.
(@gogonzo @nikolas-burkoff fyi)

@nikolas-burkoff
Copy link
Contributor

@danielinteractive we have this issue insightsengineering/teal.reporter#94 - I'll add your comment there

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants