Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

edit card names #493

Closed
wants to merge 4 commits into from
Closed

edit card names #493

wants to merge 4 commits into from

Conversation

mhallal1
Copy link
Collaborator

@github-actions
Copy link
Contributor

github-actions bot commented Nov 22, 2022

badge

Code Coverage Summary

Filename                      Stmts    Miss  Cover    Missing
--------------------------  -------  ------  -------  ----------------------------------------------
R/tm_a_pca.R                    784     784  0.00%    73-980
R/tm_a_regression.R             710     710  0.00%    93-884
R/tm_data_table.R               166     166  0.00%    59-278
R/tm_file_viewer.R              172     172  0.00%    39-241
R/tm_front_page.R               127     116  8.66%    64-206
R/tm_g_association.R            317     317  0.00%    90-467
R/tm_g_bivariate.R              611     451  26.19%   107-640, 688, 694, 698, 809, 826, 844, 864-886
R/tm_g_distribution.R           953     953  0.00%    111-1208
R/tm_g_response.R               320     320  0.00%    86-469
R/tm_g_scatterplot.R            686     686  0.00%    143-915
R/tm_g_scatterplotmatrix.R      271     252  7.01%    79-365, 419, 433
R/tm_missing_data.R            1014    1014  0.00%    59-1208
R/tm_outliers.R                 935     935  0.00%    73-1131
R/tm_t_crosstable.R             233     233  0.00%    82-354
R/tm_variable_browser.R         817     812  0.61%    62-1297
R/utils.R                       122     122  0.00%    74-352
R/zzz.R                           1       1  0.00%    2
TOTAL                          8239    8044  2.37%

Diff against main

Filename                      Stmts    Miss  Cover
--------------------------  -------  ------  -------
R/tm_a_pca.R                     +2      +2  -
R/tm_a_regression.R              +2      +2  -
R/tm_g_association.R             +1      +1  -
R/tm_g_bivariate.R               +1      +1  -0.04%
R/tm_g_distribution.R            +1      +1  -
R/tm_g_response.R                +1      +1  -
R/tm_g_scatterplot.R             +4      +4  -
R/tm_g_scatterplotmatrix.R       +1      +1  -0.03%
R/tm_missing_data.R              +2      +2  -
R/tm_outliers.R                  +1      +1  -
R/tm_t_crosstable.R              +1      +1  -
R/tm_variable_browser.R          +2      +2  -0.00%
TOTAL                           +19     +19  -0.01%

Results for commit: c196b43

Minimum allowed coverage is 80%

♻️ This comment has been updated with latest results

Comment on lines +957 to +958
card_name <- label
card_fun <- function(comment, label = card_name) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
card_name <- label
card_fun <- function(comment, label = card_name) {
card_fun <- function(comment, label = label) {

why not simply ?

Copy link
Contributor

@Polkas Polkas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks ok, please wait with merge for the teal.reporter PR.

@github-actions
Copy link
Contributor

Unit Tests Summary

  1 files    5 suites   0s ⏱️
16 tests 16 ✔️ 0 💤 0
49 runs  49 ✔️ 0 💤 0

Results for commit 42dc82b.

Comment on lines +957 to +958
card_name <- label
card_fun <- function(comment, label = card_name) {
Copy link
Contributor

@Polkas Polkas Nov 24, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
card_name <- label
card_fun <- function(comment, label = card_name) {
label <- lable
card_fun <- function(comment) {

@Polkas Polkas closed this Nov 24, 2022
@insights-engineering-bot insights-engineering-bot deleted the 94_editable_card_names@main branch July 2, 2023 03:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants