-
-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
edit card names #493
edit card names #493
Conversation
Code Coverage Summary
Diff against main
Results for commit: c196b43 Minimum allowed coverage is ♻️ This comment has been updated with latest results |
card_name <- label | ||
card_fun <- function(comment, label = card_name) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
card_name <- label | |
card_fun <- function(comment, label = card_name) { | |
card_fun <- function(comment, label = label) { |
why not simply ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks ok, please wait with merge for the teal.reporter PR.
card_name <- label | ||
card_fun <- function(comment, label = card_name) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
card_name <- label | |
card_fun <- function(comment, label = card_name) { | |
label <- lable | |
card_fun <- function(comment) { |
related to insightsengineering/teal.reporter#94