Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixes error in adverse events when ASTDY is of difftime type #1284

Merged
merged 2 commits into from
Dec 5, 2024

Conversation

averissimo
Copy link
Contributor

Pull Request

Fixes #1272

Changes description

@averissimo averissimo added the core label Dec 5, 2024
Copy link
Contributor

github-actions bot commented Dec 5, 2024

Unit Tests Summary

    1 files     70 suites   1h 11m 18s ⏱️
  724 tests   614 ✅ 110 💤 0 ❌
1 984 runs  1 759 ✅ 225 💤 0 ❌

Results for commit fce5e03.

♻️ This comment has been updated with latest results.

@averissimo averissimo enabled auto-merge (squash) December 5, 2024 16:32
Copy link
Contributor

github-actions bot commented Dec 5, 2024

Unit Test Performance Difference

Test suite performance difference
Test Suite $Status$ Time on main $±Time$ $±Tests$ $±Skipped$ $±Failures$ $±Errors$
shinytest2-tm_a_gee 💔 $130.53$ $+4.63$ $0$ $0$ $0$ $0$
shinytest2-tm_a_mmrm 💚 $740.44$ $-4.49$ $0$ $0$ $0$ $0$
shinytest2-tm_g_barchart_simple 💔 $225.90$ $+8.09$ $0$ $0$ $0$ $0$
shinytest2-tm_g_ci 💔 $97.20$ $+3.77$ $0$ $0$ $0$ $0$
shinytest2-tm_g_forest_rsp 💔 $170.53$ $+10.50$ $0$ $0$ $0$ $0$
shinytest2-tm_g_forest_tte 💔 $61.87$ $+3.48$ $0$ $0$ $0$ $0$
shinytest2-tm_g_ipp 💔 $106.75$ $+4.45$ $0$ $0$ $0$ $0$
shinytest2-tm_g_km 💔 $266.30$ $+8.00$ $0$ $0$ $0$ $0$
shinytest2-tm_g_pp_patient_timeline 💔 $247.32$ $+4.12$ $0$ $0$ $0$ $0$
shinytest2-tm_g_pp_therapy 💔 $194.93$ $+3.58$ $0$ $0$ $0$ $0$
shinytest2-tm_g_pp_vitals 💔 $86.32$ $+3.01$ $0$ $0$ $0$ $0$
shinytest2-tm_t_abnormality 💔 $67.68$ $+1.63$ $0$ $0$ $0$ $0$
shinytest2-tm_t_abnormality_by_worst_grade 💔 $68.82$ $+1.57$ $0$ $0$ $0$ $0$
shinytest2-tm_t_ancova 💔 $97.32$ $+2.91$ $0$ $0$ $0$ $0$
shinytest2-tm_t_binary_outcome 💔 $77.59$ $+1.56$ $0$ $0$ $0$ $0$
shinytest2-tm_t_coxreg 💔 $73.54$ $+1.20$ $0$ $0$ $0$ $0$
shinytest2-tm_t_events 💔 $61.78$ $+1.34$ $0$ $0$ $0$ $0$
shinytest2-tm_t_events_by_grade 💔 $88.21$ $+4.89$ $0$ $0$ $0$ $0$
shinytest2-tm_t_events_patyear 💔 $49.72$ $+2.53$ $0$ $0$ $0$ $0$
shinytest2-tm_t_events_summary 💔 $66.22$ $+3.62$ $0$ $0$ $0$ $0$
shinytest2-tm_t_exposure 💔 $75.58$ $+4.90$ $0$ $0$ $0$ $0$
shinytest2-tm_t_logistic 💔 $58.34$ $+3.48$ $0$ $0$ $0$ $0$
shinytest2-tm_t_mult_events 💔 $56.32$ $+3.12$ $0$ $0$ $0$ $0$
shinytest2-tm_t_pp_basic_info 💔 $40.27$ $+2.13$ $0$ $0$ $0$ $0$
shinytest2-tm_t_pp_laboratory 💔 $125.32$ $+6.07$ $0$ $0$ $0$ $0$
shinytest2-tm_t_pp_medical_history 💔 $63.85$ $+3.96$ $0$ $0$ $0$ $0$
shinytest2-tm_t_pp_prior_medication 💔 $74.42$ $+4.14$ $0$ $0$ $0$ $0$
shinytest2-tm_t_shift_by_arm 💔 $57.29$ $+2.26$ $0$ $0$ $0$ $0$
shinytest2-tm_t_shift_by_arm_by_worst 💔 $87.62$ $+4.73$ $0$ $0$ $0$ $0$
shinytest2-tm_t_shift_by_grade 💔 $78.57$ $+4.99$ $0$ $0$ $0$ $0$
shinytest2-tm_t_smq 💔 $57.39$ $+3.18$ $0$ $0$ $0$ $0$
shinytest2-tm_t_summary 💔 $38.38$ $+2.15$ $0$ $0$ $0$ $0$
shinytest2-tm_t_summary_by 💔 $77.91$ $+4.16$ $0$ $0$ $0$ $0$
shinytest2-tm_t_tte 💔 $65.85$ $+3.69$ $0$ $0$ $0$ $0$
Additional test case details
Test Suite $Status$ Time on main $±Time$ Test Case
shinytest2-tm_a_mmrm 💔 $48.81$ $+1.43$ e2e_tm_a_mmrm_Validate_output_on_different_selection_on_method_t_mmrm_lsmeans.
shinytest2-tm_t_pp_medical_history 💔 $12.94$ $+1.09$ e2e_tm_t_pp_medical_history_Selecting_mhbodsys_changes_the_table_and_does_not_throw_validation_errors.
shinytest2-tm_t_shift_by_grade 💔 $11.31$ $+1.05$ e2e_tm_t_shift_by_grade_Selecting_paramcd_changes_the_table_and_does_not_throw_validation_errors.
shinytest2-tm_t_summary_by 💔 $24.22$ $+1.34$ e2e_tm_t_summary_by_Selecting_arm_var_changes_the_table_and_does_not_throw_validation_errors.

Results for commit b3041af

♻️ This comment has been updated with latest results.

@averissimo averissimo merged commit ff913dd into main Dec 5, 2024
26 checks passed
@averissimo averissimo deleted the 1272_fix_difftime@main branch December 5, 2024 17:38
@github-actions github-actions bot locked and limited conversation to collaborators Dec 5, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: tm_g_pp_adverse_events fails with example
2 participants