-
-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
introduce decorators for tm_g_pp_adverse_events
#1269
introduce decorators for tm_g_pp_adverse_events
#1269
Conversation
…1187_decorate_output@main
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Example app works great.
Module appears to have a bug
@averissimo @llrs-roche beware before merging this module, it has a decorator for plot that is dependent on a decorator for a table. If table decorator breaks, you don't see a plot. This is the same scenario as in #1267 (comment) |
…1187_decorate_output@main
…1187_decorate_output@main
…1187_decorate_output@main
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When running the test I see this on the terminal when I try to create a card:
Error in self$set_content(table) :
Assertion on 'content' failed: Must inherit from class 'data.frame'/'rtables'/'TableTree'/'ElementaryTable'/'listing_df', but has class 'NULL'.
Warning in observe() :
The card could not be added to the report. Have the outputs for the report been created yet? If not please try again when they are ready. Otherwise contact your application developer
Which prevents the shiny app to generate the card.
I also left two minor comments
…1187_decorate_output@main
…1187_decorate_output@main
…1187_decorate_output@main Signed-off-by: Marcin <[email protected]>
Part of insightsengineering/teal#1371
Working Example