Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add sync condition for privacy tests #6479

Merged
merged 8 commits into from
Jan 31, 2024
Merged

add sync condition for privacy tests #6479

merged 8 commits into from
Jan 31, 2024

Conversation

macfarla
Copy link
Contributor

addresses flakiness of privacy ATs since #6302

fixes #6402

cherry-picked from #5968 - kudos to @gtebrean

@github-actions GitHub Actions
Copy link

  • I thought about documentation and added the doc-change-required label to this PR if updates are required.
  • I thought about the changelog and included a changelog update if required.
  • If my PR includes database changes (e.g. KeyValueSegmentIdentifier) I have thought about compatibility and performed forwards and backwards compatibility tests

@macfarla
Copy link
Contributor Author

privacy ATs run with this code https://app.circleci.com/jobs/github/hyperledger/besu/173800 - you can see the output is improved but that PR has other flakiness hence isolating it into this separate PR

@macfarla macfarla added privacy private transactions testing labels Jan 29, 2024
@macfarla
Copy link
Contributor Author

this will fix Message: Transaction pool not enabled errors example

pinges
pinges approved these changes Jan 31, 2024
View reviewed changes
Copy link
Contributor

@pinges pinges left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@macfarla macfarla enabled auto-merge (squash) January 31, 2024 05:40
@macfarla macfarla merged commit 1537e96 into hyperledger:main Jan 31, 2024
18 checks passed
Gabriel-Trintinalia pushed a commit to Gabriel-Trintinalia/besu that referenced this pull request Feb 1, 2024
@macfarla @gtebrean @Gabriel-Trintinalia
add sync condition for privacy tests (hyperledger#6479)
0855ab5 
* add sync condition for privacy tests

Signed-off-by: George Tebrean <[email protected]>

* headers

Signed-off-by: Sally MacFarlane <[email protected]>

* revert configs

Signed-off-by: George Tebrean <[email protected]>

---------

Signed-off-by: George Tebrean <[email protected]>
Signed-off-by: Sally MacFarlane <[email protected]>
Co-authored-by: George Tebrean <[email protected]>
Signed-off-by: Gabriel-Trintinalia <[email protected]>
@macfarla macfarla mentioned this pull request Feb 8, 2024
Merged
@macfarla macfarla deleted the privacy-sync-test-flake branch July 16, 2024 06:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gtebrean gtebrean gtebrean left review comments

@pinges pinges pinges approved these changes

Assignees
No one assigned
Labels
privacy private transactions testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

privacy ATs failing because tx pool not enabled during sync
3 participants
@macfarla @pinges @gtebrean