Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

disable privacy tests since they are currently flaky #6541

Merged
merged 1 commit into from
Feb 8, 2024

Conversation

macfarla
Copy link
Contributor

@macfarla macfarla commented Feb 8, 2024

These tests are flaky right now for 2 reasons, and work is in progress to fix.

See

Run tessera as a process (currently using docker) for ATs #5968

Also occasionally errors since the txpool is disabled during initial sync - it's been somewhat mitigated but hasn't totally fixed it

Copy link

github-actions bot commented Feb 8, 2024

  • I thought about documentation and added the doc-change-required label to this PR if updates are required.
  • I thought about the changelog and included a changelog update if required.
  • If my PR includes database changes (e.g. KeyValueSegmentIdentifier) I have thought about compatibility and performed forwards and backwards compatibility tests
  • I thought about running CI.
  • If I did not run CI, I ran as much locally as possible before pushing.

Copy link
Contributor

@siladu siladu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@macfarla macfarla enabled auto-merge (squash) February 8, 2024 02:54
@macfarla macfarla merged commit cf7fec6 into hyperledger:main Feb 8, 2024
59 checks passed
@macfarla macfarla deleted the ignore-privacy-tests branch February 9, 2024 00:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants