add sync condition for privacy tests (hyperledger#6479)

* add sync condition for privacy tests Signed-off-by: George Tebrean <[email protected]> * headers Signed-off-by: Sally MacFarlane <[email protected]> * revert configs Signed-off-by: George Tebrean <[email protected]> --------- Signed-off-by: George Tebrean <[email protected]> Signed-off-by: Sally MacFarlane <[email protected]> Co-authored-by: George Tebrean <[email protected]> Signed-off-by: Gabriel-Trintinalia <[email protected]>
Gabriel-Trintinalia · Feb 1, 2024 · 0855ab5 · 0855ab5
1 parent 86a6f49
commit 0855ab5
Show file tree

Hide file tree

Showing 21 changed files with 129 additions and 0 deletions.
diff --git a/...rc/main/java/org/hyperledger/besu/tests/acceptance/dsl/condition/priv/PrivConditions.java b/...rc/main/java/org/hyperledger/besu/tests/acceptance/dsl/condition/priv/PrivConditions.java
@@ -19,6 +19,7 @@
 import org.hyperledger.besu.ethereum.api.jsonrpc.internal.response.RpcErrorType;
 import org.hyperledger.besu.ethereum.privacy.PrivateTransaction;
 import org.hyperledger.besu.tests.acceptance.dsl.condition.Condition;
+import org.hyperledger.besu.tests.acceptance.dsl.privacy.condition.PrivateCondition;
 import org.hyperledger.besu.tests.acceptance.dsl.transaction.Transaction;
 import org.hyperledger.besu.tests.acceptance.dsl.transaction.privacy.PrivacyTransactions;
 
@@ -112,4 +113,8 @@ public Condition multiTenancyValidationFail(
       final Transaction<?> transaction, final RpcErrorType error) {
     return new ExpectJsonRpcError(transaction, error);
   }
+
+  public PrivateCondition syncingStatus(final boolean isSyncing) {
+    return new PrivateSyncingStatusCondition(transactions.syncing(), isSyncing);
+  }
 }
diff --git a/...g/hyperledger/besu/tests/acceptance/dsl/condition/priv/PrivateSyncingStatusCondition.java b/...g/hyperledger/besu/tests/acceptance/dsl/condition/priv/PrivateSyncingStatusCondition.java
@@ -0,0 +1,40 @@
+/*
+ * Copyright Hyperledger Besu Contributors.
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software distributed under the License is distributed on
+ * an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations under the License.
+ *
+ * SPDX-License-Identifier: Apache-2.0
+ */
+package org.hyperledger.besu.tests.acceptance.dsl.condition.priv;
+
+import static org.assertj.core.api.Assertions.assertThat;
+
+import org.hyperledger.besu.tests.acceptance.dsl.WaitUtils;
+import org.hyperledger.besu.tests.acceptance.dsl.privacy.PrivacyNode;
+import org.hyperledger.besu.tests.acceptance.dsl.privacy.condition.PrivateCondition;
+import org.hyperledger.besu.tests.acceptance.dsl.transaction.privacy.PrivSyncingTransactions;
+
+public class PrivateSyncingStatusCondition implements PrivateCondition {
+
+  private final PrivSyncingTransactions transaction;
+  private final boolean syncingMiningStatus;
+
+  public PrivateSyncingStatusCondition(
+      final PrivSyncingTransactions transaction, final boolean syncingStatus) {
+    this.transaction = transaction;
+    this.syncingMiningStatus = syncingStatus;
+  }
+
+  @Override
+  public void verify(final PrivacyNode node) {
+    WaitUtils.waitFor(
+        10, () -> assertThat(node.execute(transaction)).isEqualTo(syncingMiningStatus));
+  }
+}
diff --git a/...rg/hyperledger/besu/tests/acceptance/dsl/transaction/privacy/PrivSyncingTransactions.java b/...rg/hyperledger/besu/tests/acceptance/dsl/transaction/privacy/PrivSyncingTransactions.java
@@ -0,0 +1,40 @@
+/*
+ * Copyright Hyperledger Besu Contributors.
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software distributed under the License is distributed on
+ * an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations under the License.
+ *
+ * SPDX-License-Identifier: Apache-2.0
+ */
+package org.hyperledger.besu.tests.acceptance.dsl.transaction.privacy;
+
+import static org.assertj.core.api.Assertions.assertThat;
+
+import org.hyperledger.besu.tests.acceptance.dsl.transaction.NodeRequests;
+import org.hyperledger.besu.tests.acceptance.dsl.transaction.Transaction;
+
+import java.io.IOException;
+
+import org.web3j.protocol.core.methods.response.EthSyncing;
+
+public class PrivSyncingTransactions implements Transaction<Boolean> {
+
+  PrivSyncingTransactions() {}
+
+  @Override
+  public Boolean execute(final NodeRequests node) {
+    try {
+      EthSyncing response = node.eth().ethSyncing().send();
+      assertThat(response).isNotNull();
+      return response.isSyncing();
+    } catch (final IOException e) {
+      throw new RuntimeException(e);
+    }
+  }
+}
diff --git a/...va/org/hyperledger/besu/tests/acceptance/dsl/transaction/privacy/PrivacyTransactions.java b/...va/org/hyperledger/besu/tests/acceptance/dsl/transaction/privacy/PrivacyTransactions.java
@@ -62,4 +62,8 @@ public PrivGetEeaTransactionCountTransaction getEeaTransactionCount(
   public PrivGetTransactionReceiptTransaction getTransactionReceipt(final Hash transactionHash) {
     return new PrivGetTransactionReceiptTransaction(transactionHash);
   }
+
+  public PrivSyncingTransactions syncing() {
+    return new PrivSyncingTransactions();
+  }
 }
diff --git a/...t/java/org/hyperledger/besu/tests/acceptance/privacy/BftPrivacyClusterAcceptanceTest.java b/...t/java/org/hyperledger/besu/tests/acceptance/privacy/BftPrivacyClusterAcceptanceTest.java
@@ -111,6 +111,9 @@ public void setUp() throws Exception {
     charlie = createNode(containerNetwork, "node3", 2);
 
     privacyCluster.start(alice, bob, charlie);
+    alice.verify(priv.syncingStatus(false));
+    bob.verify(priv.syncingStatus(false));
+    charlie.verify(priv.syncingStatus(false));
   }
 
   private PrivacyNode createNode(

diff --git a/...g/hyperledger/besu/tests/acceptance/privacy/DeployPrivateSmartContractAcceptanceTest.java b/...g/hyperledger/besu/tests/acceptance/privacy/DeployPrivateSmartContractAcceptanceTest.java
@@ -51,6 +51,7 @@ public DeployPrivateSmartContractAcceptanceTest(
             restriction == UNRESTRICTED);
 
     privacyCluster.start(minerNode);
+    minerNode.verify(priv.syncingStatus(false));
   }
 
   @Test

diff --git a/...c/test/java/org/hyperledger/besu/tests/acceptance/privacy/EnclaveErrorAcceptanceTest.java b/...c/test/java/org/hyperledger/besu/tests/acceptance/privacy/EnclaveErrorAcceptanceTest.java
@@ -94,6 +94,9 @@ public EnclaveErrorAcceptanceTest(
             "0xBB");
     privacyCluster.start(alice, bob);
 
+    alice.verify(priv.syncingStatus(false));
+    bob.verify(priv.syncingStatus(false));
+
     final byte[] wrongPublicKeyBytes =
         EnclaveEncryptorType.EC.equals(enclaveEncryptorType)
             ? getSECP256r1PublicKeyByteArray()

diff --git a/...est/java/org/hyperledger/besu/tests/acceptance/privacy/FlexiblePrivacyAcceptanceTest.java b/...est/java/org/hyperledger/besu/tests/acceptance/privacy/FlexiblePrivacyAcceptanceTest.java
@@ -111,6 +111,10 @@ public void setUp() throws Exception {
             enclaveType,
             Optional.of(containerNetwork));
     privacyCluster.start(alice, bob, charlie);
+
+    alice.verify(priv.syncingStatus(false));
+    bob.verify(priv.syncingStatus(false));
+    charlie.verify(priv.syncingStatus(false));
   }
 
   @Test

diff --git a/...ava/org/hyperledger/besu/tests/acceptance/privacy/PluginPrivacySigningAcceptanceTest.java b/...ava/org/hyperledger/besu/tests/acceptance/privacy/PluginPrivacySigningAcceptanceTest.java
@@ -93,6 +93,8 @@ public void setup() throws IOException {
             Optional.empty());
 
     privacyCluster.start(minerNode);
+
+    minerNode.verify(priv.syncingStatus(false));
   }
 
   @Test

diff --git a/...s/src/test/java/org/hyperledger/besu/tests/acceptance/privacy/PrivCallAcceptanceTest.java b/...s/src/test/java/org/hyperledger/besu/tests/acceptance/privacy/PrivCallAcceptanceTest.java
@@ -76,6 +76,7 @@ public PrivCallAcceptanceTest(
             restriction == UNRESTRICTED);
 
     privacyCluster.start(minerNode);
+    minerNode.verify(priv.syncingStatus(false));
   }
 
   @Test

diff --git a/...edger/besu/tests/acceptance/privacy/PrivDebugGetStateRootFlexibleGroupAcceptanceTest.java b/...edger/besu/tests/acceptance/privacy/PrivDebugGetStateRootFlexibleGroupAcceptanceTest.java
@@ -76,6 +76,9 @@ public void setUp() throws IOException, URISyntaxException {
             Optional.of(containerNetwork));
 
     privacyCluster.start(aliceNode, bobNode);
+
+    aliceNode.verify(priv.syncingStatus(false));
+    bobNode.verify(priv.syncingStatus(false));
   }
 
   @Test

diff --git a/...edger/besu/tests/acceptance/privacy/PrivDebugGetStateRootOffchainGroupAcceptanceTest.java b/...edger/besu/tests/acceptance/privacy/PrivDebugGetStateRootOffchainGroupAcceptanceTest.java
@@ -72,6 +72,9 @@ public PrivDebugGetStateRootOffchainGroupAcceptanceTest(
             "0xBB");
 
     privacyCluster.start(aliceNode, bobNode);
+
+    aliceNode.verify(priv.syncingStatus(false));
+    bobNode.verify(priv.syncingStatus(false));
   }
 
   @Test

diff --git a/...rc/test/java/org/hyperledger/besu/tests/acceptance/privacy/PrivGetCodeAcceptanceTest.java b/...rc/test/java/org/hyperledger/besu/tests/acceptance/privacy/PrivGetCodeAcceptanceTest.java
@@ -55,6 +55,7 @@ public PrivGetCodeAcceptanceTest(
             restriction == UNRESTRICTED);
 
     privacyCluster.start(alice);
+    alice.verify(priv.syncingStatus(false));
   }
 
   @Test

diff --git a/...rc/test/java/org/hyperledger/besu/tests/acceptance/privacy/PrivGetLogsAcceptanceTest.java b/...rc/test/java/org/hyperledger/besu/tests/acceptance/privacy/PrivGetLogsAcceptanceTest.java
@@ -65,6 +65,7 @@ public PrivGetLogsAcceptanceTest(
             restriction == UNRESTRICTED);
 
     privacyCluster.start(node);
+    node.verify(priv.syncingStatus(false));
   }
 
   @Test

diff --git a/...rg/hyperledger/besu/tests/acceptance/privacy/PrivGetPrivateTransactionAcceptanceTest.java b/...rg/hyperledger/besu/tests/acceptance/privacy/PrivGetPrivateTransactionAcceptanceTest.java
@@ -75,6 +75,9 @@ public PrivGetPrivateTransactionAcceptanceTest(
             "0xBB");
 
     privacyCluster.start(alice, bob);
+
+    alice.verify(priv.syncingStatus(false));
+    bob.verify(priv.syncingStatus(false));
   }
 
   @Test

diff --git a/...test/java/org/hyperledger/besu/tests/acceptance/privacy/PrivacyClusterAcceptanceTest.java b/...test/java/org/hyperledger/besu/tests/acceptance/privacy/PrivacyClusterAcceptanceTest.java
@@ -108,6 +108,10 @@ public PrivacyClusterAcceptanceTest(
             false,
             false);
     privacyCluster.start(alice, bob, charlie);
+
+    alice.verify(priv.syncingStatus(false));
+    bob.verify(priv.syncingStatus(false));
+    charlie.verify(priv.syncingStatus(false));
   }
 
   @After

diff --git a/...c/test/java/org/hyperledger/besu/tests/acceptance/privacy/PrivacyGroupAcceptanceTest.java b/...c/test/java/org/hyperledger/besu/tests/acceptance/privacy/PrivacyGroupAcceptanceTest.java
@@ -94,6 +94,10 @@ public PrivacyGroupAcceptanceTest(
             false,
             false);
     privacyCluster.start(alice, bob, charlie);
+
+    alice.verify(priv.syncingStatus(false));
+    bob.verify(priv.syncingStatus(false));
+    charlie.verify(priv.syncingStatus(false));
   }
 
   @Test

diff --git a/...test/java/org/hyperledger/besu/tests/acceptance/privacy/PrivacyReceiptAcceptanceTest.java b/...test/java/org/hyperledger/besu/tests/acceptance/privacy/PrivacyReceiptAcceptanceTest.java
@@ -61,6 +61,8 @@ public PrivacyReceiptAcceptanceTest(
             restriction == UNRESTRICTED,
             "0xAA");
     privacyCluster.start(alice);
+
+    alice.verify(priv.syncingStatus(false));
   }
 
   @Test

diff --git a/...g/hyperledger/besu/tests/acceptance/privacy/PrivateContractPublicStateAcceptanceTest.java b/...g/hyperledger/besu/tests/acceptance/privacy/PrivateContractPublicStateAcceptanceTest.java
@@ -75,6 +75,9 @@ public PrivateContractPublicStateAcceptanceTest(
             restriction == UNRESTRICTED);
 
     privacyCluster.start(minerNode, transactionNode);
+
+    minerNode.verify(priv.syncingStatus(false));
+    transactionNode.verify(priv.syncingStatus(false));
   }
 
   @Test

diff --git a/...test/java/org/hyperledger/besu/tests/acceptance/privacy/PrivateGenesisAcceptanceTest.java b/...test/java/org/hyperledger/besu/tests/acceptance/privacy/PrivateGenesisAcceptanceTest.java
@@ -60,6 +60,7 @@ public PrivateGenesisAcceptanceTest(
             "AA");
 
     privacyCluster.start(alice);
+    alice.verify(priv.syncingStatus(false));
   }
 
   @Test

diff --git a/...st/java/org/hyperledger/besu/tests/acceptance/privacy/PrivateLogFilterAcceptanceTest.java b/...st/java/org/hyperledger/besu/tests/acceptance/privacy/PrivateLogFilterAcceptanceTest.java
@@ -60,6 +60,7 @@ public PrivateLogFilterAcceptanceTest(
             restriction == UNRESTRICTED);
 
     privacyCluster.start(node);
+    node.verify(priv.syncingStatus(false));
   }
 
   @Test
-Original file line number
+Diff line change
@@ Expand Up / @@ -51,6 +51,7 @@ public DeployPrivateSmartContractAcceptanceTest( @@
                 restriction == UNRESTRICTED);
         privacyCluster.start(minerNode);
+        minerNode.verify(priv.syncingStatus(false));
       }
       @Test
@@ Expand Down @@