Pre commit version #760
Merged
Pre commit version #760
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…raphnet into pre-commit-version
Aske-Rosted
approved these changes
Nov 5, 2024
This was referenced Nov 5, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since the recent update of pre-commit to 4.0,
docformatterhas failed in workflows across the globe, including in ours.This PR sets
pre-commit <= 3.8in setup.py and updates our hooks (flake8, mypy, etc) to recent versions.I took this as an opportunity to do some spring cleaning, and to get flake8 to catch unused imports. The size of this PR might look overwhelming, but there is no functional change introduced here other than what's mentioned above. The changes seen here are superficial changes to make the codebase pass the updated hooks (In total, ~108 code climate flags has been solved).
Closes #757. Tagging @AlexKurek for completeness, as you've worked on the unused imports in the past.