Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] Correct DynEdge instantiation in documentation #762

Merged
merged 2 commits into from
Nov 5, 2024

Conversation

samadpls
Copy link
Collaborator

@samadpls samadpls commented Nov 1, 2024

closes #714

Replace detector.nb_outputs with graph_definition.nb_outputs, aligning with the correct usage in DynEdge instantiation.

@samadpls samadpls requested a review from RasmusOrsoe November 1, 2024 14:18
@RasmusOrsoe
Copy link
Collaborator

@samadpls thank you for this contribution! The problem with pre-commit is now fixed in main. If you update the branch, the failing checks in this PR are likely to pass (see #760).

@samadpls
Copy link
Collaborator Author

samadpls commented Nov 5, 2024

@samadpls thank you for this contribution! The problem with pre-commit is now fixed in main. If you update the branch, the failing checks in this PR are likely to pass (see #760).

@RasmusOrsoe Acknowledged, thank you! 😊

Copy link
Collaborator

@RasmusOrsoe RasmusOrsoe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@samadpls samadpls merged commit 8903e35 into graphnet-team:main Nov 5, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Documentation typo: Models in Graphnet Instantiating a StandardModel
2 participants