Improvements for inelasticity reconstructions and other utilities #763
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pweigel
commented
Nov 6, 2024
| @@ -13,7 +13,7 @@ | |||
| from graphnet.utilities.imports import has_icecube_package | |||
|
|
|||
| if has_icecube_package() or TYPE_CHECKING: | |||
| from icecube import ( | |||
| from icecube import ( # noqa: F401 | |||
There was a problem hiding this comment.
I needed to add this because LeptonInjector isn't used directly, but it needs to be imported for icetray to recognize the "EventProperties" frame object type.
RasmusOrsoe
requested changes
Nov 12, 2024
There was a problem hiding this comment.
@pweigel thank you for these contributions!
I added a small comment related to the duplication of the set_gcd.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request implements some changes for training inelasticity reconstructions and adds other utilities:
I3TruthExtractorcan now determine starting events using the event vertex and the convex hull of the detector volume (using the GCD file). The convex hull can also be expanded withextend_boundary. Some other utilities in this class use the "boundaries" list, but I think these could be redone to use the convex hull. I should note I had to override theset_gcdfunction since the geometry is added after instantiation.I3TruthExtractorcan now identify MC produced with LeptonInjector and get the relevant quantities.sub_event_stream.IceMixNodesto enable/disable the random pulse sampling (default True).VisibleInelasticityReconstructiontaskMAELoss