feat: Add Unsupported variant to CacheError and ObjectFileStatus
#1541
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Swatinem
approved these changes
Oct 21, 2024
tobias-wilfert
approved these changes
Oct 21, 2024
loewenheim
added a commit
to getsentry/sentry
that referenced
this pull request
Nov 11, 2024
This is intended to improve the user experience for cases like getsentry/symbolicator#1539 in which we attempt to symbolicate a CLR event with a Windows PDB file. It maps the "unsupported" frame status returned by Symbolicator (getsentry/symbolicator#1541) to a new error variant. Properly displaying and explaining this error is left for a future PR.
|
getsentry/sentry#80517 is the corresponding Sentry change. |
4 tasks
loewenheim
added a commit
to getsentry/sentry
that referenced
this pull request
Nov 11, 2024
This is intended to improve the user experience for cases like getsentry/symbolicator#1539 in which we attempt to symbolicate a CLR event with a Windows PDB file. It maps the "unsupported" frame status returned by Symbolicator (getsentry/symbolicator#1541) to a new error variant. Properly displaying and explaining this error is left for a future PR.
loewenheim
added a commit
to getsentry/sentry
that referenced
this pull request
Nov 12, 2024
This is intended to improve the user experience for cases like getsentry/symbolicator#1539 in which we attempt to symbolicate a CLR event with a Windows PDB file. It maps the "unsupported" frame status returned by Symbolicator (getsentry/symbolicator#1541) to a new error variant. Properly displaying and explaining this error is left for a future PR.
loewenheim
added a commit
to getsentry/sentry
that referenced
this pull request
Nov 12, 2024
Take 2 of #80517. This is intended to improve the user experience for cases like getsentry/symbolicator#1539 in which we attempt to symbolicate a CLR event with a Windows PDB file. It maps the "unsupported" frame status returned by Symbolicator (getsentry/symbolicator#1541) to a new error variant. Properly displaying and explaining this error is left for a future PR.
loewenheim
added a commit
that referenced
this pull request
Nov 15, 2024
This is the part of #1541 that just introduces the variants but doesn't yet produce them anywhere.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a new
CacheError/ObjectFileStatusvariant for cases where a debug file is OK, but can't be used for the purpose for which it was requested. Currently the only such case is symbolicating .NET events with portable PDB files (see getsentry/symbolic#871).In addition, this also makes Symbolicator request both portable PDB and Windows PDB files for symbolicating .NET events. The reason for this is that although Windows PDB files can never be used for that purpose, at least this way we get a concrete error status we can report to the user. If we don't do that, we get cases like #1539.
This will also require changes in
sentryto handle the new status variant. It probably shouldn't be merged before that logic is in place.