feat(symbolication): Introduce "unsupported dsym" error #80578
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is intended to improve the user experience for cases like getsentry/symbolicator#1539 in which we attempt to symbolicate a CLR event with a Windows PDB file. It maps the "unsupported" frame status returned by Symbolicator (getsentry/symbolicator#1541) to a new error variant. Properly displaying and explaining this error is left for a future PR.
github-actions
bot
added
Scope: Frontend
|
🚨 Warning: This pull request contains Frontend and Backend changes! It's discouraged to make changes to Sentry's Frontend and Backend in a single pull request. The Frontend and Backend are not atomically deployed. If the changes are interdependent of each other, they must be separated into two pull requests and be made forward or backwards compatible, such that the Backend or Frontend can be safely deployed independently. Have questions? Please ask in the |
Swatinem
approved these changes
Nov 12, 2024
4 tasks
loewenheim
changed the title
Codecov ReportAttention: Patch coverage is ✅ All tests successful. No failed tests found.
Additional details and impacted files@@ Coverage Diff @@
## master #80578 +/- ##
==========================================
- Coverage 78.36% 78.36% -0.01%
==========================================
Files 7206 7206
Lines 318720 318723 +3
Branches 43905 43906 +1
==========================================
- Hits 249771 249760 -11
- Misses 62589 62598 +9
- Partials 6360 6365 +5 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Take 2 of #80517.
This is intended to improve the user experience for cases like getsentry/symbolicator#1539 in which we attempt to symbolicate a CLR event with a Windows PDB file. It maps the "unsupported" frame status returned by Symbolicator (getsentry/symbolicator#1541) to a new error variant. Properly displaying and explaining this error is left for a future PR.