feat(symbolication): Introduce "unsupported dsym" error #80517
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is intended to improve the user experience for cases like getsentry/symbolicator#1539 in which we attempt to symbolicate a CLR event with a Windows PDB file. It maps the "unsupported" frame status returned by Symbolicator (getsentry/symbolicator#1541) to a new error variant. Properly displaying and explaining this error is left for a future PR.
github-actions
bot
added
the
Scope: Backend
4 tasks
Swatinem
approved these changes
Nov 11, 2024
|
PR reverted: 58684f0 |
getsentry-bot
added a commit
that referenced
this pull request
Nov 11, 2024
…)" This reverts commit c00fabf. Co-authored-by: loewenheim <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #80517 +/- ##
==========================================
- Coverage 78.36% 78.35% -0.02%
==========================================
Files 7204 7204
Lines 318728 318731 +3
Branches 43928 43929 +1
==========================================
- Hits 249781 249732 -49
- Misses 62597 62638 +41
- Partials 6350 6361 +11 |
loewenheim
added a commit
that referenced
this pull request
Nov 12, 2024
This is intended to improve the user experience for cases like getsentry/symbolicator#1539 in which we attempt to symbolicate a CLR event with a Windows PDB file. It maps the "unsupported" frame status returned by Symbolicator (getsentry/symbolicator#1541) to a new error variant. Properly displaying and explaining this error is left for a future PR.
loewenheim
added a commit
that referenced
this pull request
Nov 12, 2024
Take 2 of #80517. This is intended to improve the user experience for cases like getsentry/symbolicator#1539 in which we attempt to symbolicate a CLR event with a Windows PDB file. It maps the "unsupported" frame status returned by Symbolicator (getsentry/symbolicator#1541) to a new error variant. Properly displaying and explaining this error is left for a future PR.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is intended to improve the user experience for cases like getsentry/symbolicator#1539 in which we attempt to symbolicate a CLR event with a Windows PDB file. It maps the "unsupported" frame status returned by Symbolicator (getsentry/symbolicator#1541) to a new error variant. Properly displaying and explaining this error is left for a future PR.