fix(issues): Remove duplicate span in sdk_crash_monitoring #82910
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This op is already being auto-instrumented in run_post_process_job, the duplicate span here with the same name is not helpful when looking at aggregates. This renames the op and adds another around config building - in the future I suspect we can get a very easy win by not rebuilding config for every single event - this will give us some data to back up that theory.
github-actions
bot
added
the
Scope: Backend
mrduncan
changed the title
roggenkemper
approved these changes
Jan 4, 2025
Suspect IssuesThis pull request was deployed and Sentry observed the following issues:
Did you find this useful? React with a 👍 or 👎 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This op is already being auto-instrumented in run_post_process_job, the duplicate span here with the same name is not helpful when looking at aggregates.
This renames the op and adds another around config building - in the future I suspect we can get a very easy win by not rebuilding config for every single event - this will give us some data to back up that theory.
Aggregate showing the 2x duplicate (
update_existing_attachmentsis fixed in a separate PR): https://sentry.sentry.io/traces/?groupBy=span.op&mode=aggregate&project=1&query=span.op%3Atasks.post_process_group.%2A&statsPeriod=24h&visualize=%7B%22chartType%22%3A1%2C%22yAxes%22%3A%5B%22count%28span.duration%29%22%5D%7DSee also: #82911