Skip to content

Commit

Permalink
fix(issues): Remove duplicate span in update_existing_attachments (#8…
Browse files Browse the repository at this point in the history
…2911)

This is already auto-instrumented in run_post_process_job with the exact
same span op.

See also: #82910
  • Loading branch information
mrduncan authored Jan 6, 2025
1 parent f5eff5d commit d405386
Showing 1 changed file with 5 additions and 7 deletions.
12 changes: 5 additions & 7 deletions src/sentry/tasks/post_process.py
Original file line number Diff line number Diff line change
Expand Up @@ -437,15 +437,13 @@ def update_existing_attachments(job):
1) ingested prior to the event via the standalone attachment endpoint.
2) part of a different group before reprocessing started.
"""
# Patch attachments that were ingested on the standalone path.
with sentry_sdk.start_span(op="tasks.post_process_group.update_existing_attachments"):
from sentry.models.eventattachment import EventAttachment
from sentry.models.eventattachment import EventAttachment

event = job["event"]
event = job["event"]

EventAttachment.objects.filter(project_id=event.project_id, event_id=event.event_id).update(
group_id=event.group_id
)
EventAttachment.objects.filter(project_id=event.project_id, event_id=event.event_id).update(
group_id=event.group_id
)


def fetch_buffered_group_stats(group):
Expand Down

0 comments on commit d405386

Please sign in to comment.