Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(issues): Remove duplicate span in sdk_crash_monitoring #82910

Merged
merged 1 commit into from
Jan 6, 2025
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 6 additions & 8 deletions src/sentry/tasks/post_process.py
Original file line number Diff line number Diff line change
Expand Up @@ -1292,15 +1292,13 @@ def sdk_crash_monitoring(job: PostProcessJob):
if not features.has("organizations:sdk-crash-detection", event.project.organization):
return

configs = build_sdk_crash_detection_configs()
if not configs or len(configs) == 0:
return None
with sentry_sdk.start_span(op="post_process.build_sdk_crash_config"):
configs = build_sdk_crash_detection_configs()
if not configs or len(configs) == 0:
return None

with sentry_sdk.start_span(op="tasks.post_process_group.sdk_crash_monitoring"):
sdk_crash_detection.detect_sdk_crash(
event=event,
configs=configs,
)
with sentry_sdk.start_span(op="post_process.detect_sdk_crash"):
sdk_crash_detection.detect_sdk_crash(event=event, configs=configs)


def plugin_post_process_group(plugin_slug, event, **kwargs):
Expand Down
Loading