-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: insert disk cache on hybrid cache fetch miss #591
Conversation
Signed-off-by: MrCroxx <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #591 +/- ##
==========================================
- Coverage 86.14% 86.10% -0.04%
==========================================
Files 59 59
Lines 7620 7631 +11
==========================================
+ Hits 6564 6571 +7
- Misses 1056 1060 +4 ☔ View full report in Codecov by Sentry. |
cherry pick #591 Signed-off-by: MrCroxx <[email protected]>
Signed-off-by: MrCroxx <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for the fix
Signed-off-by: MrCroxx <[email protected]>
Signed-off-by: MrCroxx <[email protected]>
* refactor: remove atomic op in #591 Signed-off-by: MrCroxx <[email protected]> * refactor: use deversion future to simplify? code Signed-off-by: MrCroxx <[email protected]> * chore: remove unused Signed-off-by: MrCroxx <[email protected]> * chore: pass typo Signed-off-by: MrCroxx <[email protected]> * chore: tiny refactor Signed-off-by: MrCroxx <[email protected]> * refactor: remove default bound to refine Signed-off-by: MrCroxx <[email protected]> * refactor: refine code Signed-off-by: MrCroxx <[email protected]> * chore: refine code Signed-off-by: MrCroxx <[email protected]> --------- Signed-off-by: MrCroxx <[email protected]>
What's changed and what's your intention?
Previously, foyer inserts disk cache on in-memory cache eviction. After v0.9.x, foyer inserts disk cache on hybrid cache insertion. But
fetch()
only callsinsert
on in-memory cache, not hybrid cacheinsert()
.This PR fixes the bug by proactively inserting the disk cache on hybrid fetch miss.
Benchmark (new baseline)
Checklist
make all
(ormake fast
instead if the old tests are not modified) in my local environment.Related issues or PRs (optional)
risingwavelabs/risingwave#17473