Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(storage): fix abnormal file cache miss on fetch #17513

Merged
merged 7 commits into from
Jul 2, 2024
Merged

fix(storage): fix abnormal file cache miss on fetch #17513

merged 7 commits into from
Jul 2, 2024

Conversation

MrCroxx
Copy link
Contributor

@MrCroxx MrCroxx commented Jul 1, 2024

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

Details: foyer-rs/foyer#591

#17473

Checklist

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • I have added test labels as necessary. See details.
  • I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features Sqlsmith: Sql feature generation #7934).
  • My PR contains breaking changes. (If it deprecates some features, please create a tracking issue to remove them in the future).
  • All checks passed in ./risedev check (or alias, ./risedev c)
  • My PR changes performance-critical code. (Please run macro/micro-benchmarks and show the results.)
  • My PR contains critical fixes that are necessary to be merged into the latest release. (Please check out the details)

Documentation

  • My PR needs documentation updates. (Please use the Release note section below to summarize the impact on users)

Release note

If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.

@MrCroxx MrCroxx self-assigned this Jul 1, 2024
@MrCroxx MrCroxx requested a review from a team as a code owner July 1, 2024 06:45
@MrCroxx MrCroxx requested review from hzxa21 and Li0k July 1, 2024 06:45
@github-actions github-actions bot added the type/fix Bug fix label Jul 1, 2024
@MrCroxx MrCroxx added the need-cherry-pick-release-1.10 Open a cherry-pick PR to branch release-1.10 after the current PR is merged label Jul 2, 2024
@MrCroxx MrCroxx added this pull request to the merge queue Jul 2, 2024
Merged via the queue into main with commit cd4660e Jul 2, 2024
29 of 30 checks passed
@MrCroxx MrCroxx deleted the xx/fmiss branch July 2, 2024 13:40
MrCroxx added a commit that referenced this pull request Jul 3, 2024
github-merge-queue bot pushed a commit that referenced this pull request Jul 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
need-cherry-pick-release-1.10 Open a cherry-pick PR to branch release-1.10 after the current PR is merged type/fix Bug fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants