Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: remove atomic op in #591 #594

Merged
merged 8 commits into from
Jul 2, 2024
Merged

refactor: remove atomic op in #591 #594

merged 8 commits into from
Jul 2, 2024

Conversation

MrCroxx
Copy link
Collaborator

@MrCroxx MrCroxx commented Jul 2, 2024

Signed-off-by: MrCroxx [email protected]## What's changed and what's your intention?

Please explain IN DETAIL what the changes are in this PR and why they are needed. :D

Compared with #593

Checklist

  • I have written the necessary rustdoc comments
  • I have added the necessary unit tests and integration tests
  • I have passed make all (or make fast instead if the old tests are not modified) in my local environment.

Related issues or PRs (optional)

#591

@MrCroxx MrCroxx added this to the v0.10 milestone Jul 2, 2024
@MrCroxx MrCroxx self-assigned this Jul 2, 2024
MrCroxx added 3 commits July 2, 2024 13:02
Signed-off-by: MrCroxx <[email protected]>
Signed-off-by: MrCroxx <[email protected]>
Signed-off-by: MrCroxx <[email protected]>
Copy link

codecov bot commented Jul 2, 2024

Codecov Report

Attention: Patch coverage is 90.17857% with 11 lines in your changes missing coverage. Please review.

Project coverage is 86.09%. Comparing base (ef3f139) to head (47e42b2).

Current head 47e42b2 differs from pull request most recent head dde8386

Please upload reports for the commit dde8386 to get more accurate results.

Files Patch % Lines
foyer-memory/src/generic.rs 83.33% 6 Missing ⚠️
foyer-memory/src/cache.rs 80.95% 4 Missing ⚠️
foyer/src/hybrid/cache.rs 92.30% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #594      +/-   ##
==========================================
+ Coverage   86.02%   86.09%   +0.06%     
==========================================
  Files          59       60       +1     
  Lines        7643     7710      +67     
==========================================
+ Hits         6575     6638      +63     
- Misses       1068     1072       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@MrCroxx MrCroxx mentioned this pull request Jul 2, 2024
3 tasks
Signed-off-by: MrCroxx <[email protected]>
@MrCroxx MrCroxx enabled auto-merge (squash) July 2, 2024 07:53
@MrCroxx MrCroxx merged commit c036ed7 into main Jul 2, 2024
13 checks passed
@MrCroxx MrCroxx deleted the xx/ratomicv2 branch July 2, 2024 07:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

1 participant