Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: replace obsolete JS media type #2111

Merged
merged 9 commits into from
Jun 4, 2023

Conversation

euj1n0ng
Copy link
Contributor

@euj1n0ng euj1n0ng commented Sep 28, 2022

Summary of Changes

A minor fix according to RFC 9239 - Updates to ECMAScript Media Types

Related Issues

Closes #2110

CaselIT
CaselIT previously approved these changes Sep 28, 2022
@codecov
Copy link

codecov bot commented Sep 28, 2022

Codecov Report

Merging #2111 (5dda080) into master (c7c790f) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##            master     #2111   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           62        62           
  Lines         6802      6805    +3     
  Branches      1097      1098    +1     
=========================================
+ Hits          6802      6805    +3     
Impacted Files Coverage Δ
falcon/constants.py 100.00% <100.00%> (ø)
falcon/response.py 100.00% <100.00%> (ø)

CaselIT
CaselIT previously approved these changes Sep 28, 2022
@vytas7 vytas7 changed the title Replace obsolete JS media type feat: replace obsolete JS media type Oct 3, 2022
Copy link
Member

@vytas7 vytas7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this change warrants a newandimproved news fragment.

@kgriffs
Copy link
Member

kgriffs commented Oct 28, 2022

@vytas7 I can add the news fragment after this is merged if we want to just move forward with this.

@vytas7
Copy link
Member

vytas7 commented Oct 30, 2022

@kgriffs another problem is that this PR, while good-to-go from our side, would probably not address the issue the author had at hand. I wrote a comment on the linked issue. Would you think it would be a good idea to override certain media types with our constants when serving static files to make sure the interpreter's defaults (which may even vary with OS) don't take over?

vytas7
vytas7 previously approved these changes Jun 3, 2023
Copy link
Member

@vytas7 vytas7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi again @euj1n0ng, and thanks for this PR! 👍

I've now added a newsfragment, and updated our machinery somewhat to hopefully address WebOfTrust/keripy#316.

@vytas7 vytas7 requested review from CaselIT and kgriffs June 3, 2023 16:04
CaselIT
CaselIT previously approved these changes Jun 4, 2023
falcon/constants.py Show resolved Hide resolved
@vytas7 vytas7 dismissed stale reviews from CaselIT and themself via 5dda080 June 4, 2023 09:06
@vytas7 vytas7 self-requested a review June 4, 2023 09:06
@vytas7 vytas7 requested a review from CaselIT June 4, 2023 09:06
@vytas7 vytas7 merged commit 7dff4ff into falconry:master Jun 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Replace the obsolete JS media type
4 participants