-
-
Notifications
You must be signed in to change notification settings - Fork 947
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: replace obsolete JS media type #2111
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2111 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 62 62
Lines 6802 6805 +3
Branches 1097 1098 +1
=========================================
+ Hits 6802 6805 +3
|
5e98347
to
083ddbf
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this change warrants a newandimproved
news fragment.
@vytas7 I can add the news fragment after this is merged if we want to just move forward with this. |
@kgriffs another problem is that this PR, while good-to-go from our side, would probably not address the issue the author had at hand. I wrote a comment on the linked issue. Would you think it would be a good idea to override certain media types with our constants when serving static files to make sure the interpreter's defaults (which may even vary with OS) don't take over? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi again @euj1n0ng, and thanks for this PR! 👍
I've now added a newsfragment, and updated our machinery somewhat to hopefully address WebOfTrust/keripy#316.
Summary of Changes
A minor fix according to RFC 9239 - Updates to ECMAScript Media Types
Related Issues
Closes #2110