feat(response): prefer falcon.MEDIA_* constants to stdlib's `mimety…

…pes`

docs/_newsfragments/2110.newandimproved.rst

@@ -0,0 +1,6 @@
+Following the recommendation from
+`RFC 9239 <https://www.rfc-editor.org/rfc/rfc9239>`__, the
+:ref:`MEDIA_JS <media_type_constants>` constant has been updated to
+``text/javascript``. Furthermore, this and other media type constants are now
+preferred to the stdlib's :mod:`mimetypes` for the initialization of
+:attr:`~falcon.ResponseOptions.static_media_types`.

falcon/constants.py

@@ -105,9 +105,9 @@
 # contrary to the RFCs.
 MEDIA_XML = 'application/xml'
 
-# NOTE: According to RFC 9239, Changed the intended usage of the
-# media type "text/javascript" from OBSOLETE to COMMON. Changed
-# the intended usage for all other script media types to obsolete.
+# NOTE(euj1n0ng): According to RFC 9239, Changed the intended usage of the
+#   media type "text/javascript" from OBSOLETE to COMMON. Changed
+#   the intended usage for all other script media types to obsolete.
 MEDIA_JS = 'text/javascript'
 
 # NOTE(kgriffs): According to RFC 6838, most text media types should
@@ -137,6 +137,28 @@
     ]
 )
 
+# NOTE(vytas): We strip the preferred charsets from the default static file
+#   type mapping as it is hard to make any assumptions without knowing which
+#   files are going to be served. Moreover, the popular web servers (like
+#   Nginx) do not try to guess either.
+_DEFAULT_STATIC_MEDIA_TYPES = tuple(
+    (ext, media_type.split(';', 1)[0])
+    for ext, media_type in (
+        ('.bmp', MEDIA_BMP),
+        ('.gif', MEDIA_GIF),
+        ('.htm', MEDIA_HTML),
+        ('.html', MEDIA_HTML),
+        ('.jpeg', MEDIA_JPEG),
+        ('.jpg', MEDIA_JPEG),
+        ('.js', MEDIA_JS),
+        ('.png', MEDIA_PNG),
+        ('.txt', MEDIA_TEXT),
+        ('.xml', MEDIA_XML),
+        ('.yaml', MEDIA_YAML),
+        ('.yml', MEDIA_YAML),
+    )
+)
+
 # NOTE(kgriffs): Special singleton to be used internally whenever using
 #   None would be ambiguous.
 _UNSET = object()

falcon/response.py

@@ -17,6 +17,7 @@
 import functools
 import mimetypes
 
+from falcon.constants import _DEFAULT_STATIC_MEDIA_TYPES
 from falcon.constants import _UNSET
 from falcon.constants import DEFAULT_MEDIA_TYPE
 from falcon.errors import HeaderNotSupported
@@ -1246,4 +1247,5 @@ def __init__(self):
 
         if not mimetypes.inited:
             mimetypes.init()
-        self.static_media_types = mimetypes.types_map
+        self.static_media_types = mimetypes.types_map.copy()
+        self.static_media_types.update(_DEFAULT_STATIC_MEDIA_TYPES)

tests/test_response.py

@@ -65,13 +65,14 @@ def test_response_removed_stream_len(resp):
 def test_response_option_mimetype_init(monkeypatch):
     mock = MagicMock()
     mock.inited = False
+    mock.types_map = {'.js': 'application/javascript'}
     monkeypatch.setattr('falcon.response.mimetypes', mock)
 
     ro = ResponseOptions()
 
-    assert ro.static_media_types is mock.types_map
+    assert ro.static_media_types['.js'] == 'text/javascript'
+
     mock.reset_mock()
     mock.inited = True
     ro = ResponseOptions()
-    assert ro.static_media_types is mock.types_map
     mock.init.assert_not_called()