Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace the obsolete JS media type #2110

Closed
euj1n0ng opened this issue Sep 28, 2022 · 6 comments · Fixed by #2111
Closed

Replace the obsolete JS media type #2110

euj1n0ng opened this issue Sep 28, 2022 · 6 comments · Fixed by #2111
Labels
good first issue Comment on this issue if you'd like to volunteer to work on this. Thanks! maintenance
Milestone
Version 4.0

Comments

@euj1n0ng
Copy link
Contributor

RFC-4329 is obsolete.

According to RFC-9239,

  • Changed the intended usage of the media type "text/javascript" from OBSOLETE to COMMON.
  • Changed the intended usage for all other script media types to obsolete.
@euj1n0ng euj1n0ng mentioned this issue Sep 28, 2022
Closed
@vytas7
Copy link
Member

vytas7 commented Sep 28, 2022

Thanks for heads up @euj1n0ng!

Falcon isn't heavily tied to Javascript, so I suppose this is just about updating constants.py::MEDIA_JS. Would you like to create a PR?

@vytas7 vytas7 added maintenance good first issue Comment on this issue if you'd like to volunteer to work on this. Thanks! needs contributor Comment on this issue if you'd like to volunteer to work on this. Thanks! labels Sep 28, 2022
@euj1n0ng euj1n0ng mentioned this issue Sep 28, 2022
Merged
@MS-Ignis
Copy link

MS-Ignis commented Oct 5, 2022

Hey, this is my first time contributing to open source. Is this issue still open? @vytas7 @euj1n0ng
Also will this contribute to hacktoberfest?

@euj1n0ng
Copy link
Contributor Author

euj1n0ng commented Oct 5, 2022

Hey, this is my first time contributing to open source. Is this issue still open? @vytas7 @euj1n0ng Also will this contribute to hacktoberfest?

The relevant PR: #2111
The motivation: WebOfTrust/keripy#316

@vytas7
Copy link
Member

vytas7 commented Oct 5, 2022 •
edited
Loading

Aha, I was unaware of the context. In fact, we need to check if this type constant is actually enforced when serving static files, otherwise you'll need to submit a PR to the CPython (or PyPy) interpreter itself 🙂

(Or we need to modify Falcon to prioritize these constants vs the system's mimetypes -- take a look at response.py:1246 if you want to update your PR in this vein.)

@vytas7 vytas7 removed the needs contributor Comment on this issue if you'd like to volunteer to work on this. Thanks! label Oct 15, 2022
@vytas7 vytas7 added this to the Version 4.0 milestone Jan 8, 2023
@harshashetty67
Copy link

Hi all, is this issue fixed? if not, I would like to contribute. I'm new to open source and was looking for good first issues.
@vytas7 @euj1n0ng

@vytas7
Copy link
Member

vytas7 commented Jun 3, 2023 •
edited
Loading

Hi @harshashetty67, this is not fixed, but there is already an open PR.

@harshashetty67 if you are okay with contributing documentation, we have a bunch of good first issues. We don't have that many good first issues for coding at the moment...
You can view all issues that need a contributor here: https://github.com/falconry/falcon/issues?q=is%3Aopen+is%3Aissue+label%3A%22needs+contributor%22
Maybe one of these could suit you?

And as said, if you're fine with writing documentation, then we have tons of good first issues. I can help you picking something there.

Edit: somewhere between coding and docs, the following one would be a nice addition IMHO: #1355

vytas7 added a commit to vytas7/falcon that referenced this issue Oct 6, 2024
@vytas7
docs(newsfragments): clean up newandimproved up to falconry#2110
6436374
vytas7 added a commit that referenced this issue Oct 6, 2024
@vytas7 @CaselIT
docs: clean up newsfragments & other docs for 4.0.0b1 (#2358)
a81354a 
* docs: clean up newsfragments & other docs for `4.0.0b1`

* docs: add more `versionadded` directives

* docs: clean up more newsfragments from the breakingchange section

* docs: clean up xml_error_serialization docs & more

* docs(newsfragments): clean up newandimproved up to #2110

* docs: clean up more newsfragments

* docs: update wording as per review suggestion `docs/_newsfragments/2213.newandimproved.rst`

Co-authored-by: Federico Caselli <[email protected]>

* docs: show inherited members from base of test result classes

---------

Co-authored-by: Federico Caselli <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Comment on this issue if you'd like to volunteer to work on this. Thanks! maintenance
Projects
None yet
Milestone
Version 4.0
Development

Successfully merging a pull request may close this issue.

feat: replace obsolete JS media type euj1n0ng/falcon
4 participants
@vytas7 @harshashetty67 @euj1n0ng @MS-Ignis