Run commit signing checks on pull_request_target #270
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sajith
added
the
no changelog
Pull Request Test Coverage Report for Build 7451197051
💛 - Coveralls |
"Code checks" action did not run at all on a PR with the previous commit, and now I am confused about pull_request_target. Perhaps this event is triggered only in the case of when there's "forked" repository? https://stackoverflow.com/questions/74957218/what-is-the-difference-between-pull-request-and-pull-request-target-event-in-git https://github.blog/2020-08-03-github-actions-improvements-for-fork-and-pull-request-workflows/
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1Password/check-signed-commits-action@v1 is designed to be used with
pull_request_targetorpull_requestevents, with the former preferred. It fails onpushevents, such as when a PR is merged. Here's an example of such a failure:https://github.com/fabric-testbed/fabrictestbed-extensions/actions/runs/7400337712/job/20133749344
Also sneaks in a changelog sub-title change because of the recent release. :-)