Skip to content

Commit

Permalink
Merge pull request #270 from fabric-testbed/268.commit-signing-check-…
Browse files Browse the repository at this point in the history
…on-pr

Run commit signing checks on pull_request_target
  • Loading branch information
sajith authored Jan 8, 2024
2 parents 82633d8 + fa27917 commit d12ec20
Show file tree
Hide file tree
Showing 2 changed files with 9 additions and 0 deletions.
5 changes: 5 additions & 0 deletions .github/workflows/checks.yml
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@ on:
branches:
- "main"
pull_request:
pull_request_target:

permissions:
contents: read
Expand All @@ -25,7 +26,11 @@ jobs:
fetch-depth: 0 # since we need to diff against origin/main.

# https://github.com/marketplace/actions/check-signed-commits-in-pr
# runs on pull_request_target and pull_request events, but
# pull_request_target is preferred because of the ability to
# leave comments on external PRs created from forks.
- name: Check that commits are signed
if: github.event_name == 'pull_request' || github.event_name == 'pull_request_target'
uses: 1Password/check-signed-commits-action@v1

- name: Set up Python 3.9
Expand Down
4 changes: 4 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,10 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0

## [Unreleased]



## [1.6.0] - 2024-01-03

### Fixed

- Fix an error in `Node.list_networks()` (Issue
Expand Down

0 comments on commit d12ec20

Please sign in to comment.