Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run commit signing checks on pull_request_target #270

Merged
merged 3 commits into from
Jan 8, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .github/workflows/checks.yml
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@ on:
branches:
- "main"
pull_request:
pull_request_target:

permissions:
contents: read
Expand All @@ -25,7 +26,11 @@ jobs:
fetch-depth: 0 # since we need to diff against origin/main.

# https://github.com/marketplace/actions/check-signed-commits-in-pr
# runs on pull_request_target and pull_request events, but
# pull_request_target is preferred because of the ability to
# leave comments on external PRs created from forks.
- name: Check that commits are signed
if: github.event_name == 'pull_request' || github.event_name == 'pull_request_target'
uses: 1Password/check-signed-commits-action@v1

- name: Set up Python 3.9
Expand Down
4 changes: 4 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,10 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0

## [Unreleased]



## [1.6.0] - 2024-01-03

### Fixed

- Fix an error in `Node.list_networks()` (Issue
Expand Down