Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extract frame draw detection to its own component #1793

Open
wants to merge 1 commit into
base: hho/improve-ui-load-tests
Choose a base branch
from

Conversation

bidetofevil
Copy link
Collaborator

@bidetofevil bidetofevil commented Jan 5, 2025

Goal

Extract the code to detect when a app startup is ended by the first activity drawing its first frame into its own class so it can be used for the UI Load trace as well.

Copy link

codecov bot commented Jan 5, 2025

Codecov Report

Attention: Patch coverage is 43.75000% with 36 lines in your changes missing coverage. Please review.

Project coverage is 85.52%. Comparing base (ac7156a) to head (eb153a4).

Files with missing lines Patch % Lines
...ndroid/embracesdk/internal/ui/FirstDrawDetector.kt 26.53% 31 Missing and 5 partials ⚠️
Additional details and impacted files

Impacted file tree graph

@@                      Coverage Diff                      @@
##           hho/improve-ui-load-tests    #1793      +/-   ##
=============================================================
+ Coverage                      85.50%   85.52%   +0.01%     
=============================================================
  Files                            467      468       +1     
  Lines                          10961    10962       +1     
  Branches                        1628     1629       +1     
=============================================================
+ Hits                            9372     9375       +3     
+ Misses                           861      857       -4     
- Partials                         728      730       +2     
Files with missing lines Coverage Δ
...racesdk/internal/capture/startup/StartupTracker.kt 90.24% <100.00%> (+39.69%) ⬆️
...internal/injection/DataCaptureServiceModuleImpl.kt 95.45% <100.00%> (+0.10%) ⬆️
...d/embracesdk/internal/logging/InternalErrorType.kt 100.00% <100.00%> (ø)
...ndroid/embracesdk/internal/ui/FirstDrawDetector.kt 26.53% <26.53%> (ø)

... and 2 files with indirect coverage changes

@bidetofevil bidetofevil marked this pull request as ready for review January 6, 2025 08:31
@bidetofevil bidetofevil requested a review from a team as a code owner January 6, 2025 08:31
@bidetofevil bidetofevil requested review from fractalwrench and removed request for a team January 6, 2025 08:31
Copy link
Contributor

@fractalwrench fractalwrench left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bidetofevil bidetofevil force-pushed the hho/improve-ui-load-tests branch from a66de26 to fd312e6 Compare January 6, 2025 16:05
@bidetofevil bidetofevil requested a review from fnewberg as a code owner January 6, 2025 16:05
@bidetofevil bidetofevil force-pushed the hho/extract-draw-detector branch from 9d55875 to 81c9825 Compare January 6, 2025 16:05
@bidetofevil bidetofevil force-pushed the hho/improve-ui-load-tests branch from fd312e6 to 5a66b7b Compare January 6, 2025 19:53
@bidetofevil bidetofevil force-pushed the hho/extract-draw-detector branch from 81c9825 to 932e35c Compare January 6, 2025 19:54
@bidetofevil bidetofevil force-pushed the hho/improve-ui-load-tests branch from 5a66b7b to 708a6ec Compare January 6, 2025 21:17
@bidetofevil bidetofevil force-pushed the hho/extract-draw-detector branch from 932e35c to aa5d62f Compare January 6, 2025 21:17
@bidetofevil bidetofevil force-pushed the hho/improve-ui-load-tests branch from 708a6ec to 6ed5939 Compare January 6, 2025 21:22
@bidetofevil bidetofevil force-pushed the hho/extract-draw-detector branch from aa5d62f to 376acad Compare January 6, 2025 21:22
@bidetofevil bidetofevil force-pushed the hho/improve-ui-load-tests branch from 6ed5939 to ac7156a Compare January 6, 2025 22:38
@bidetofevil bidetofevil force-pushed the hho/extract-draw-detector branch from 376acad to eb153a4 Compare January 6, 2025 22:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants