-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extract frame draw detection to its own component #1793
base: hho/improve-ui-load-tests
Are you sure you want to change the base?
Conversation
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## hho/improve-ui-load-tests #1793 +/- ##
=============================================================
+ Coverage 85.50% 85.52% +0.01%
=============================================================
Files 467 468 +1
Lines 10961 10962 +1
Branches 1628 1629 +1
=============================================================
+ Hits 9372 9375 +3
+ Misses 861 857 -4
- Partials 728 730 +2
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
a66de26
to
fd312e6
Compare
9d55875
to
81c9825
Compare
fd312e6
to
5a66b7b
Compare
81c9825
to
932e35c
Compare
5a66b7b
to
708a6ec
Compare
932e35c
to
aa5d62f
Compare
708a6ec
to
6ed5939
Compare
aa5d62f
to
376acad
Compare
6ed5939
to
ac7156a
Compare
376acad
to
eb153a4
Compare
Goal
Extract the code to detect when a app startup is ended by the first activity drawing its first frame into its own class so it can be used for the UI Load trace as well.