API and integration tests for manually ending UI load traces

[bidetofevil]

Goal

Add in the ability to specify that a a UI Load trace should wait for a manual end as well as a public API to do that.

[bidetofevil]

• Make FirstDrawDetector a singleton #1796
• Add unregistering of draw callback #1795
• Add render detection to UI Load traces #1794
• Extract frame draw detection to its own component #1793
• Restructure assertions to remove magic numbers #1791
• API and integration tests for manually ending UI load traces #1790 👈 (View in Graphite)
• Allow all activities to ge traced by default #1789
• Remove the reset event #1788
• Change start time of UI Load traces #1787
• Align event emitter names with lifecycle methods #1786
• main

This stack of pull requests is managed by Graphite. Learn more about stacking.

[codecov]

Codecov Report

Attention: Patch coverage is 92.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 85.46%. Comparing base (505d329) to head (59d7670).

Files with missing lines	Patch %	Lines
...nternal/api/delegate/InstrumentationApiDelegate.kt	75.00%	0 Missing and 2 partials ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #1790      +/-   ##
==========================================
- Coverage   85.47%   85.46%   -0.02%     
==========================================
  Files         466      467       +1     
  Lines       10948    10961      +13     
  Branches     1626     1628       +2     
==========================================
+ Hits         9358     9368      +10     
  Misses        861      861              
- Partials      729      732       +3     

Files with missing lines	Coverage Δ
.../embrace/android/embracesdk/internal/api/SdkApi.kt	0.00% <ø> (ø)
.../embracesdk/internal/capture/activity/UiLoadExt.kt	100.00% <100.00%> (ø)
...main/java/io/embrace/android/embracesdk/Embrace.kt	85.18% <100.00%> (+0.18%)	⬆️
.../java/io/embrace/android/embracesdk/EmbraceImpl.kt	77.10% <100.00%> (+0.27%)	⬆️
...nternal/api/delegate/InstrumentationApiDelegate.kt	75.00% <75.00%> (ø)

... and 1 file with indirect coverage changes

[fractalwrench]

This looks good but I'd like for swazzler instrumentation to be in place (or approved) before it gets merged

[fractalwrench]

I'm not 100% on this name for a public API as it doesn't detail that this is about the Embrace SDK/UI load tracking, and there are potentially a lot of things that could be traced in an activity. Having said that, I don't have a better suggestion. Would you say the key components of this annotation would be that Embrace will automatically trace lifecycle events of any activity annotated with it?

[bidetofevil]

Yeah I honestly hate this name too, but I also couldn't come up with something better. I wanted to make it similar to TracedActivity

Perhaps CustomLoadTracedActivity? And we can rename the other one LoadTracedActivity?

[fractalwrench]

Sounds good 👍

[bidetofevil]

Sounds good. I'll get that going first thing I can delve back into the code.

[github-actions]

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

OpenSSF Scorecard

Package	Version	Score	Details

Scanned Files