Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Align event emitter names with lifecycle methods #1786

Merged
merged 1 commit into from
Jan 6, 2025

Conversation

bidetofevil
Copy link
Collaborator

@bidetofevil bidetofevil commented Dec 31, 2024

Goal

A renaming of interface and objects to make them align better with their purpose. Note there are additional naming changes down the line, i.e. exit becomes discard.

Copy link
Contributor

github-actions bot commented Dec 31, 2024

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

OpenSSF Scorecard

PackageVersionScoreDetails

Scanned Files

Copy link

codecov bot commented Dec 31, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.44%. Comparing base (d95f64c) to head (f42484a).
Report is 4 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1786   +/-   ##
=======================================
  Coverage   85.44%   85.44%           
=======================================
  Files         466      466           
  Lines       10979    10979           
  Branches     1631     1631           
=======================================
  Hits         9381     9381           
  Misses        867      867           
  Partials      731      731           
Files with missing lines Coverage Δ
.../embracesdk/internal/capture/activity/UiLoadExt.kt 100.00% <100.00%> (ø)
...dk/internal/capture/activity/UiLoadTraceEmitter.kt 88.43% <ø> (ø)

Copy link
Contributor

@fractalwrench fractalwrench left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bidetofevil bidetofevil force-pushed the hho/event-emitter-naming branch from 0943da7 to f42484a Compare January 6, 2025 16:05
Copy link
Collaborator Author

bidetofevil commented Jan 6, 2025

Merge activity

  • Jan 6, 2:26 PM EST: A user started a stack merge that includes this pull request via Graphite.
  • Jan 6, 2:26 PM EST: A user merged this pull request with Graphite.

@bidetofevil bidetofevil merged commit 26d96b1 into main Jan 6, 2025
8 checks passed
@bidetofevil bidetofevil deleted the hho/event-emitter-naming branch January 6, 2025 19:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants