Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass "key" to converter function for parse method #7

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

mm-gmbd
Copy link

@mm-gmbd mm-gmbd commented Feb 21, 2017

No description provided.

@mm-gmbd
Copy link
Author

mm-gmbd commented Feb 21, 2017

@ppetrosh -- opened a PR with the required code changes to get it working, but I don't think it's complete. Need to update the error message for "# of arguments" (considering there's an argument added and that increases the # of args) and update the parametercCount stuff if/when "getinfos" is available.

@mm-gmbd
Copy link
Author

mm-gmbd commented Feb 21, 2017

Also, haven't updated any of the unit tests

@ppetrosh ppetrosh self-assigned this Feb 22, 2017
@ppetrosh
Copy link
Contributor

Thank you, Max. Let me take it over from this point.

@toddallen97
Copy link
Contributor

Is there any plan to incorporate this PR to the library?

@betzrhodes
Copy link

A review for this pull request is currently in our backlog, since there is still additional work to do before this could be integrated into the library. We cannot estimate the time frame for this feature at the moment.

Current blockers are: identifying number of parameters, since impOS doesn't currently support getinfos, and test coverage for this update. Ideally this update will be a non-breaking change for current users of the converter function.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants