Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass key in custom converter function -- updated #16

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from

Conversation

toddallen97
Copy link
Contributor

@toddallen97 toddallen97 commented Jul 3, 2019

This PR extends the modifications made in PR #7 to work with the ability to convert data not in a structure (PR #14).
I have:

  • Added tests for the custom converter function, including checking keys.
  • Added tests to ensure bad data is being rejected.
  • Added tests to ensure data not in a structure is being processed correctly
  • Updated README examples and version numbers

@betzrhodes I am aware that getinfos support is in the works, but with the version control system in place, users can #require the 1.0.2 release or the 2.0.0 release with this feature, that way the change doesn't need to break existing code.

I hope this helps address some of the blockers!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant