Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

If parsing a table with keys/values, pass key to the converter #6

Open
mm-gmbd opened this issue Feb 21, 2017 · 4 comments
Open

If parsing a table with keys/values, pass key to the converter #6

mm-gmbd opened this issue Feb 21, 2017 · 4 comments

Comments

@mm-gmbd
Copy link

mm-gmbd commented Feb 21, 2017

Would be handy if, when parsing a table in parse method, that the key be passed to the optional converter function.

@mm-gmbd
Copy link
Author

mm-gmbd commented Feb 21, 2017

@ppetrosh -- not sure if you're managing this library, but figured I'd give you a mention to get things started.

@mm-gmbd
Copy link
Author

mm-gmbd commented Feb 21, 2017

This ended up being a simple change -- just pass the available key variable as the 3rd argument to _convert method. Unfortunately this is a breaking change (requires others using the library to update so that converter functions take 3 args instead of 2).

@ppetrosh
Copy link
Contributor

Hi Max do you have a PR for the change? Or can you share it with me so that I can take it over from there?

@mm-gmbd
Copy link
Author

mm-gmbd commented Feb 21, 2017

Hey Pavel -- opened PR #7

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants