-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update SQL for non-priority case in cell plot #384
Update SQL for non-priority case in cell plot #384
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add a test case for this change or modify it if it already exists.
@upendrakumbham reported a bug regarding t-SNE plots. The default Due to I don't have I can generate the same bug locally in this way. To check the default parameterisation value I check the json endpoint
In conclusion by now, the bug comes from the backend not frontend issue and we may encounter the same bug if the database has only one entry for one of the cell plot type method. |
I tested the relevant SQL implemented in
where I get a wrong query response, which contains all the other |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All looks good, please fix the build before merge.
…t-correctly-displayed-in-scxa
…splayed-in-scxa' of https://github.com/ebi-gene-expression-group/atlas-web-single-cell into 374-experiments-default-plot-option-is-not-correctly-displayed-in-scxa
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This a bugfix related to the issue #374.
In the previous implementation, we suppose at least one highest
priority
value, i.e. larger than0
, would be curated in the tablescxa-dimension-reduction
. However, due to lack of enough data or curated by mistakes, we do not always have the highestprioriy
value, so I fix the postgres query to select proper entries in both cases.There are some data populating issues on dev PostgreSQL database, which has been reported to data production team members on Slack. Please follow the updates via https://ebi-fg.slack.com/archives/C7U2CRS58/p1706111909985499.