Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Experiment's default plot option is not correctly displayed in SCXA #374

Closed
ke4 opened this issue Nov 29, 2023 · 5 comments · Fixed by #384
Closed

Experiment's default plot option is not correctly displayed in SCXA #374

ke4 opened this issue Nov 29, 2023 · 5 comments · Fixed by #384
Assignees
Labels
bug Something isn't working

Comments

@ke4
Copy link
Contributor

ke4 commented Nov 29, 2023

We discussed the use case that should be implement for this with @upendrakumbham and @@pmb59.
There are 2 separate condition that we have to fullfill:

  • If in the priority column in scxa_dimension_reduction table there is a non zero value (most probably 1) for a specific plot type for a specific experiment then the web app should show that one as default.
  • If every value in the priority column in scxa_dimension_reduction table is 0, then the web app should calculate a middle value for Plot options and display that one. For example: if we have 9 Plot options then we should display the 5th one.

Steps to reproduce:

  1. Go to Browse experiments tab in SCXA.
  2. Select Transcriptional programs of circuit assembly in the Drosophila visual system

Expected result:
The middle Plot option is selected, as all the priority column in scxa_dimension_reduction table is 0.

Actual result:
The 1st Plot option is selected.

You should also test it with E-ANND-3 in your local environment. Please load that experiment into your local environment , if you have not done it, yet. The instructions to follow: Add an AnnData experiment to our local SCXA

Please see below how to reproduce the bug with that experiment.


For historical reason I preserved the original ticket description and you can find it below.

Original title: E-ANND-3 experiment by default is not displaying plots in SCXA

Steps to reproduce:

  1. Go to Browse experiments tab in SCXA.
  2. Select Tabula Sapiens - Smart-seq2 dataset experiment

Expected result:

Experiment's data should show up with the plots diagram.

Actual result:

An error message appears on the screen.

Image

@ke4 ke4 added the bug Something isn't working label Nov 29, 2023
@ke4 ke4 self-assigned this Nov 29, 2023
@ke4
Copy link
Contributor Author

ke4 commented Nov 29, 2023

Here is the log from Solr cloud when it tries to load E-ANND-3:

anndata_not_appearing.log

I need to investigate this more closely.

@ke4
Copy link
Contributor Author

ke4 commented Dec 11, 2023

It looks like that I had an issue previously with my local SCXA environment regarding the data in my local DB.
I repopulated it and I managed to display E-ANND-3 although there is a problem with the default view.
I attached the default view here:

Image

@ke4
Copy link
Contributor Author

ke4 commented Dec 11, 2023

If you go and select the only plot option, then the cell plots are correctly appear:

Image

@ke4
Copy link
Contributor Author

ke4 commented Dec 11, 2023

After some investigation it looks like the backend code is not correctly calculating the default Plot options for a specific plot type for a specific experiment.

The DB query that used by this method is not correct:

public Map<String, List<JsonObject>> fetchDefaultPlotMethodWithParameterisation(String experimentAccession) {

It does not take account that more than one values could be the same (in this case: 0).

@ke4 ke4 changed the title Investigate why E-ANND-3 experiment is not displaying plots in SCXA E-ANND-3 experiment is not displaying plots in SCXA Dec 11, 2023
@ke4 ke4 changed the title E-ANND-3 experiment is not displaying plots in SCXA E-ANND-3 experiment by default is not displaying plots in SCXA Dec 11, 2023
@ke4 ke4 changed the title E-ANND-3 experiment by default is not displaying plots in SCXA Experiment's default plot option is not correctly displayed in SCXA Dec 12, 2023
@ke4 ke4 assigned lingyun1010 and unassigned ke4 Dec 12, 2023
@lingyun1010
Copy link
Contributor

I fixed the software bugs but in the meanwhile I found some errors in PostgreSQL database on dev. I took a screenshot on what we have in the scxa-dimension_reduction search results. The issue is we have different formats on some experiments with t-SNE and tsne, umap and UMAP and mixture of three as shown in the screenshot.

Image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants