-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tooltips for partial positions in triggers modal #326
Conversation
…e I ad ded them to app by accident
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
"requires": true, | ||
"packages": { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not sure why these got removed 🤔
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oh rip weird, I ran npm run bump_version
, and this is what it outputted... also unsure if lockfileVersion
is significant here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fwiw, I pulled 1.1.46 locally into my v4-web branch and it seems to work fine. but unsure if I should be more worried about this 👀
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
actually, maybe this is causing this error hmm, I think it's unrelated (tried deploying with old version of localization and error is still there, I think it's separate issue with a cosmos upgrade maybe)
Added from mocks here. Also added translations from here into
tooltips.json
(instead of justapp.json
)