Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tooltips for partial positions in triggers modal #326

Merged
merged 2 commits into from
Mar 8, 2024

Conversation

moo-onthelawn
Copy link
Contributor

@moo-onthelawn moo-onthelawn commented Mar 7, 2024

Added from mocks here. Also added translations from here into tooltips.json (instead of just app.json)

Copy link

vercel bot commented Mar 7, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
v4-localization ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 7, 2024 10:59pm

@moo-onthelawn moo-onthelawn merged commit c44e867 into main Mar 8, 2024
3 checks passed
@moo-onthelawn moo-onthelawn deleted the mulan-partialTooltips branch March 8, 2024 00:44
"requires": true,
"packages": {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not sure why these got removed 🤔

Copy link
Contributor Author

@moo-onthelawn moo-onthelawn Mar 8, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh rip weird, I ran npm run bump_version, and this is what it outputted... also unsure if lockfileVersion is significant here

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fwiw, I pulled 1.1.46 locally into my v4-web branch and it seems to work fine. but unsure if I should be more worried about this 👀

Copy link
Contributor Author

@moo-onthelawn moo-onthelawn Mar 8, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

actually, maybe this is causing this error hmm, I think it's unrelated (tried deploying with old version of localization and error is still there, I think it's separate issue with a cosmos upgrade maybe)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants