Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix terms of use links #556

Merged
merged 2 commits into from
Jun 24, 2024
Merged

fix terms of use links #556

merged 2 commits into from
Jun 24, 2024

Conversation

moo-onthelawn
Copy link
Contributor

@moo-onthelawn moo-onthelawn commented Jun 24, 2024

something small I noticed where we weren't linking the whole terms of use links in app because translations were slightly off. would ideally like to fix so we can have consistent styling

Copy link

vercel bot commented Jun 24, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
v4-localization ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 24, 2024 8:13pm

Copy link
Contributor

@tyleroooo tyleroooo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Technically kind of a breaking change, right? Follow up frontend PR? Will it break mobile apps when they upgrade?

@moo-onthelawn
Copy link
Contributor Author

Technically kind of a breaking change, right? Follow up frontend PR? Will it break mobile apps when they upgrade?

eh yeah i did do a quick skim and didn't seem to see use in mobile apps but hm cc @mike-dydx @ruixhuang // fyi if you upgrade, you'll want to add a param for these two keys if they're in use!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants