-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix naming of take profit orders #400
Merged
moo-onthelawn
merged 2 commits into
main
from
mulan/ct-659-fix-naming-of-orders-in-orders-fills-table
Apr 23, 2024
Merged
Fix naming of take profit orders #400
moo-onthelawn
merged 2 commits into
main
from
mulan/ct-659-fix-naming-of-orders-in-orders-fills-table
Apr 23, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
jaredvu
approved these changes
Apr 22, 2024
moo-onthelawn
deleted the
mulan/ct-659-fix-naming-of-orders-in-orders-fills-table
branch
April 23, 2024 14:21
This was referenced Apr 23, 2024
Closed
This was referenced May 10, 2024
Merged
Merged
This was referenced May 24, 2024
This was referenced Jun 3, 2024
This was referenced Jun 10, 2024
Merged
Merged
This was referenced Jun 18, 2024
Merged
Merged
This was referenced Jun 26, 2024
Merged
This was referenced Jul 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
old behavior was that
Take Profit Market
read asMarket Profit
shortened (i.e. in orders table) andTake Profit Limit
read asProfit
, which didn't make much sense. Synced with Se to update this so thatTake Profit Market
->Take Profit
andTake Profit Limit
stays the same.