TRCL-3542 Add global command strings for translation #256
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
moo-onthelawn
changed the title
config/localization/en/app.json
Outdated
| @@ -1340,7 +1340,6 @@ | |||
| "LAUNCH_INCENTIVES_DESCRIPTION":"Each season, you can earn rewards for trading on dYdX Chain. Trade to earn your spot on the leaderboard.", | |||
| "LEADERBOARD": "Leaderboard", | |||
| "POINTS":"{POINTS} points", | |||
| "POWERED_BY":"POWERED BY", | |||
There was a problem hiding this comment.
duplicate key (it's already in app.general.powered_by so this isn't even recognized in the generated app.ts file) ((hence, this isn't used anywhere in v4-web))
config/localization/de/app.json
Outdated
| @@ -186,7 +186,6 @@ | |||
| "PERPETUALS": "Perpetuals", | |||
| "PNL": "G&V", | |||
| "POSITION": "Position", | |||
| "POWERED_BY": "Powered By", | |||
There was a problem hiding this comment.
deleted non-en translations of POWERED_BY so that it could be retranslated in caps lock - not sure if this is the right protocol - should I keep them in instead?
There was a problem hiding this comment.
it's likely that Lilt will just replace these back with the original "Powered By" -- I usually just rename the key, so you can say POWERED_BY_ALL_CAPS: "POWERED BY" and that guarantees they'll translate based on the newest value
moo-onthelawn
force-pushed
the
mulan-cmdk
branch
from
c7dd135 to
8085ced
Compare
ah ty - done!
ooh created a new string, will follow up to update usage |
Internationalize strings from useGlobalCommands.
There was also a duplicate key of "POWERED_BY" - removed the unused one (the autogenerate script only maps one of the instances of the key) and replaced the existing one to be fully capitalized.update: looks like it's used by v4-native-ios, so didn't want to deleteNote: I deleted the old translations of "POWERED_BY" in the other language files so they could be re-translated - is that the right way of going about things? Or should I keep them in?