Fixes DuckPlayer Experiment issue #3421
Merged
+36
−15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
afterxleep
changed the title
Bunn
reviewed
Oct 9, 2024
| if duckPlayerExperiment.isEnrolled && duckPlayerExperiment.isExperimentCohort { | ||
| return encodeUserValues() | ||
| } | ||
| return nil |
There was a problem hiding this comment.
Maybe we could add a comment here explaining the different behavior when returning nil? Or maybe just the asana task for context
Bunn
approved these changes
Oct 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/0/1207252092703676/1208450923559111/f
Description:
Steps to test this PR:
Go to Settings > All Debug Settings > Override DuckPlayer Experiment (Control)
Force-close / Restart the app
Go to SERP, and then confirm you can this page:
Go to SERP, search for a video and tap it
Confirm you see the old overlay
Internal references:
Software Engineering Expectations
Technical Design Template