Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Daniel/dp.experiment.fix #3420

Closed
wants to merge 3 commits into from
Closed

Daniel/dp.experiment.fix #3420

wants to merge 3 commits into from

Conversation

afterxleep
Copy link
Collaborator

@afterxleep afterxleep commented Oct 9, 2024

Task/Issue URL: https://app.asana.com/0/1207252092703676/1208450923559111/f
Tech Design URL:
CC:

Description:

  • Fix an issue with DP experiment that causes Control users to not see overlays

Steps to test this PR:

  1. Go to Settings > All Debug Settings > Override DuckPlayer Experiment (Control)

  2. Force-close / Restart the app

  3. Go to SERP, and then confirm you can this page:
    10-09 at 13 38 @2x

  4. Go to SERP, search for a video and tap it

  5. Confirm you see the old overlay

10-09 at 13 32 @2x


Internal references:

Software Engineering Expectations
Technical Design Template

@afterxleep
Copy link
Collaborator Author

Replaced by #3421

@afterxleep afterxleep closed this Oct 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant