Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updates Internal release with 7.139.1 hotfix changes #3426

Merged
merged 1 commit into from
Oct 10, 2024
Merged

Updates Internal release with 7.139.1 hotfix changes #3426

merged 1 commit into from
Oct 10, 2024
+35 −14

Conversation

afterxleep
Copy link
Collaborator

@afterxleep afterxleep commented Oct 10, 2024 •
edited
Loading

Adds an experiment override for Control group, and accounts for the DuckPlayer Feature flag to be active when replying to the FE requests.

Task/Issue URL: https://app.asana.com/0/1207252092703676/1208450923559111/f

Description:

  • Internal release updates with hotfix
  • Account for FF when sending user values to the Frontend

Steps to test this PR:

  1. Go to Settings > All Debug Settings > Override DuckPlayer Experiment (Control)

  2. Force-close / Restart the app

  3. Go to SERP, and then confirm you can this page:
    10-09 at 13 38 @2x

  4. Go to SERP, search for a video and tap it

  5. Confirm you see the old overlay

10-09 at 13 32 @2x

@afterxleep
Update SB & Add Feature Flag
42dc17e 
Adds an experiment override for Control group, and accounts for the DuckPlayer Feature flag to be active when replying to the FE requests.
@afterxleep afterxleep changed the base branch from main to release/7.140.0 October 10, 2024 14:00
@afterxleep afterxleep requested a review from Bunn October 10, 2024 14:02
@afterxleep
Copy link
Collaborator Author

@Bunn These are the changes you've reviewed and approved in. #3421

There is one difference though, and that is that I added a Feature flag check here too (better safe than sorry): https://github.com/duckduckgo/iOS/pull/3426/files#diff-0ea71c12b12d7dc638044e8d81230ceb6a54488ed33a57512a533e9c4bd329e8R191

@afterxleep afterxleep merged commit 0eb1c3a into release/7.140.0 Oct 10, 2024
23 checks passed
@afterxleep afterxleep deleted the daniel/dp.experiment.fixes branch October 10, 2024 14:07
samsymons added a commit that referenced this pull request Oct 10, 2024
@samsymons
Merge branch 'main' into sam/persistent-pixels
f4e380f 
* main:
  Refactor Core Data usage in RemoteMessagingStore (#3425)
  Release 7.140.0-1 (#3428)
  Updates Internal release with 7.139.1 hotfix changes (#3426)
  Disabling autocompletion for website suggestions on macOS (#3401)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Bunn Bunn Bunn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@afterxleep @Bunn