Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for targetPercentile RMF rule parameter #2824

Merged
merged 10 commits into from
May 15, 2024
Merged

Add support for targetPercentile RMF rule parameter #2824

merged 10 commits into from
May 15, 2024

Conversation

samsymons
Copy link
Contributor

Task/Issue URL: https://app.asana.com/0/0/1207234800675204/f
Tech Design URL:
CC:

Description:

Client PR for duckduckgo/BrowserServicesKit#809.

This adds support for the targetPercentile feature of RMF.

Steps to test this PR:

  1. This test involves testing with a custom RMF manifest - point your app at the manifest in this PR and check that the message shows (it has 90% likelihood of doing so, if it doesn't then reset your installation of the app and try again)
  2. Now push a change to that PR to set the percentile very low and test that the message doesn't appear

Device Testing:

  • iPhone SE (1st Gen)
  • iPhone 8
  • iPhone X
  • iPhone 14 Pro
  • iPad

OS Testing:

  • iOS 14
  • iOS 15
  • iOS 16

Theme Testing:

  • Light theme
  • Dark theme
Internal references:

Software Engineering Expectations
Technical Design Template

@samsymons samsymons requested a review from amddg44 May 6, 2024 03:22
@samsymons samsymons mentioned this pull request May 6, 2024
Merged
6 tasks
samsymons added 2 commits May 5, 2024 20:24
@samsymons
Merge branch 'main' into sam/remote-messaging-target-percentile
b743a3f 
# By Dominik Kapusta
# Via GitHub
* main:
  Enable field validation for Sync payloads (#2807)

# Conflicts:
#	DuckDuckGo.xcodeproj/project.pbxproj
#	DuckDuckGo.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved
@samsymons
Update BSK reference after fixing conflicts.
0d2500e
@github-actions github-actions bot added the bot: not in app board Added by automation for pull requests with tasks not added to iOS App Board Asana project label May 6, 2024
@samsymons samsymons removed the bot: not in app board Added by automation for pull requests with tasks not added to iOS App Board Asana project label May 6, 2024
samsymons added 2 commits May 10, 2024 07:39
@samsymons
Merge branch 'main' into sam/remote-messaging-target-percentile
3625033 
# By amddg44 (3) and others
# Via GitHub (1) and amddg44 (1)
* main:
  Enable gzip compression for Sync PATCH payloads (#2805)
  sync error notify (#2822)
  Wire up VPN error UI (#2826)
  Mergeback from release/7.119.0
  Release 7.119.0-1 (#2840)
  Add temporary survey to Passwords screen (#2834)
  Upload logs on cancel (#2836)
  Add bookmarks to top hits suggestions on iOS (#2835)
  Fix Maestro reporting for e2e tests (#2713)
  support marketplace kit (#2833)
  Enable attribution flag (#2825)
  Release 7.119.0-0 (#2831)
  Fix subscriptions glitch in Settings (#2828)
  Delegate SecureVault KeyStore Events in All Scenarios  (#2827)
  Clears subscription cache on restore (#2823)

# Conflicts:
#	DuckDuckGo.xcodeproj/project.pbxproj
#	DuckDuckGo.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved
@samsymons
Update BSK reference.
8039f78
amddg44
amddg44 approved these changes May 10, 2024
View reviewed changes
Copy link
Contributor

@amddg44 amddg44 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The json in the manifest contains survery query params which aren't supported yet so I used my own jsonblob for testing and all worked perfectly 🚀

@samsymons
Merge branch 'main' into sam/remote-messaging-target-percentile
5bce50d 
* main:
  use old provisioning profile template for the alpha build (#2848)
  Update tests to handle new Settings UI (#2844)
  Release 7.120.0-0 (#2846)
samsymons added a commit to duckduckgo/BrowserServicesKit that referenced this pull request May 14, 2024
@samsymons
Add support for targetPercentile RMF rule parameter (#809)
6568d48 
Required:

Task/Issue URL: https://app.asana.com/0/0/1207234800675204/f
iOS PR: duckduckgo/iOS#2824
macOS PR: duckduckgo/macos-browser#2772
What kind of version bump will this require?: Major

Description:

This PR adds support for the new targetPercentile option in RMF rules. This allows us to specify a percentage of users for whom the rule matches.
samsymons added 3 commits May 14, 2024 18:29
@samsymons
Merge branch 'main' into sam/remote-messaging-target-percentile
cdc37d2 
# By Jacek Łyp
# Via Jacek Łyp (4) and GitHub (1)
* main: (31 commits)
  Release 7.120.0-1 (#2853)
  Uncomment test code
  Use different function to check if in portrait
  Address Ship Review requests
  Fix more swiftlint issues
  Fix swiftlint issues
  Fix brainfart
  Don't show the toast when there are still some DaxDialogs left
  Make sure we fire reload, on just going back from background
  Hide bar if user does any navigation
  Fix UI glitches
  WIP
  Update BSK refs
  Utilize the custom PixelExperiment class
  Add more pixels
  Add top sliding view
  Address GH comments
  Addres PR comments
  Add translations
  Fix background color
  ...

# Conflicts:
#	DuckDuckGo.xcodeproj/project.pbxproj
#	DuckDuckGo.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved
@samsymons
Set BSK to 145.0.0.
876690f
@samsymons
Commit the .git removal. Seems like Xcode wants that to happen now?
1b404d9
@samsymons samsymons merged commit 4a31402 into main May 15, 2024
14 checks passed
@samsymons samsymons deleted the sam/remote-messaging-target-percentile branch May 15, 2024 02:05
samsymons added a commit that referenced this pull request May 15, 2024
@samsymons
Merge branch 'main' into graeme/ship-ios-vpn-widget
5662d17 
* main: (42 commits)
  Remove run loop use, use DI for Bookmarks Caching Search (#2854)
  Bump BSK Version (#2843)
  Release 7.120.0-3 (#2861)
  Update BSK that reverts broken site pixel encoding change (#2860)
  Tweak sync Maestro tests (#2858)
  Release 7.120.0-2 (#2856)
  Fix for how we encode broken site reports (#2855)
  New Autofill pixels for KPIs (#2849)
  Add support for `targetPercentile` RMF rule parameter (#2824)
  Release 7.120.0-1 (#2853)
  Uncomment test code
  Use different function to check if in portrait
  use old provisioning profile template for the alpha build (#2848)
  Address Ship Review requests
  Update tests to handle new Settings UI (#2844)
  Fix more swiftlint issues
  Fix swiftlint issues
  Fix brainfart
  Don't show the toast when there are still some DaxDialogs left
  Make sure we fire reload, on just going back from background
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amddg44 amddg44 amddg44 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@samsymons @amddg44