Add support for targetPercentile RMF rule parameter
#809
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We used to only care about attributes and their rule ID, but now we’re starting to add additional properties so it’s time to turn rule into a class.
samsymons
commented
May 6, 2024
| let rules: [Int: [MatchingAttribute]] | ||
| let rules: [RemoteConfigRule] |
There was a problem hiding this comment.
This is technically less efficient than the old implementation, but a bit simpler. We have so few rules at one time that the difference here is negligible, but let me know if you feel otherwise.
samsymons
commented
May 6, 2024
| } | ||
|
|
||
| public struct RemoteConfigTargetPercentile { | ||
| let before: Float? |
There was a problem hiding this comment.
This is the percentile that will be sampled before we apply the attributes. The alternative here is that we do the sampling after matching attributes, but it was agreed that we'll only support the before case for now.
10 tasks
* main: Enable field validation for Sync payloads (#804)
samsymons
commented
May 6, 2024
* main: Enable gzip compression for Sync PATCH payloads (#803) autofill: send current language in runtime config (#808) Password manager survey update (#811) on iOS allow bookmarks in top hits (#812) Rename tests to avoid conflicts (#813) Bat.js fix (fix for installing content blocking rules multiple times) (#779) Pixels automatic naming prefixing fixed (#810)
amddg44
approved these changes
May 10, 2024
There was a problem hiding this comment.
LGTM! Have tested thoroughly over the last couple of days and this all looks really great; nice work @samsymons
* main: Support new privacy dashboard source (#798)
samsymons
added a commit
to duckduckgo/macos-browser
that referenced
this pull request
May 15, 2024
Task/Issue URL: https://app.asana.com/0/414235014887631/1207234800675204/f Tech Design URL: CC: Description: Client PR for duckduckgo/BrowserServicesKit#809
samsymons
added a commit
to duckduckgo/iOS
that referenced
this pull request
May 15, 2024
Task/Issue URL: https://app.asana.com/0/0/1207234800675204/f Tech Design URL: CC: Description: Client PR for duckduckgo/BrowserServicesKit#809. This adds support for the targetPercentile feature of RMF.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please review the release process for BrowserServicesKit here.
Required:
Task/Issue URL: https://app.asana.com/0/0/1207234800675204/f
iOS PR: duckduckgo/iOS#2824
macOS PR: duckduckgo/macos-browser#2772
What kind of version bump will this require?: Major
Description:
This PR adds support for the new
targetPercentileoption in RMF rules. This allows us to specify a percentage of users for whom the rule matches.Steps to test this PR:
OS Testing:
Internal references:
Software Engineering Expectations
Technical Design Template