Add support for targetPercentile RMF rule parameter (#2824)

Task/Issue URL: https://app.asana.com/0/0/1207234800675204/f Tech Design URL: CC: Description: Client PR for duckduckgo/BrowserServicesKit#809. This adds support for the targetPercentile feature of RMF.
duckduckgo · May 15, 2024 · 4a31402 · 4a31402
1 parent cb58823
commit 4a31402
Show file tree

Hide file tree

Showing 4 changed files with 12 additions and 6 deletions.
diff --git a/DuckDuckGo.xcodeproj/project.pbxproj b/DuckDuckGo.xcodeproj/project.pbxproj
@@ -9826,7 +9826,7 @@
 			repositoryURL = "https://github.com/DuckDuckGo/BrowserServicesKit";
 			requirement = {
 				kind = exactVersion;
-				version = 144.0.7;
+				version = 145.0.0;
 			};
 		};
 		9F8FE9472BAE50E50071E372 /* XCRemoteSwiftPackageReference "lottie-spm" */ = {

diff --git a/DuckDuckGo.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved b/DuckDuckGo.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved
@@ -32,8 +32,8 @@
       "kind" : "remoteSourceControl",
       "location" : "https://github.com/DuckDuckGo/BrowserServicesKit",
       "state" : {
-        "revision" : "c1ce2cb5015890868bac3be85fbac3794ab30cb4",
-        "version" : "144.0.7"
+        "revision" : "6568d48c381042275c1936c6301a5100dea1c278",
+        "version" : "145.0.0"
       }
     },
     {
@@ -138,7 +138,7 @@
     {
       "identity" : "swift-argument-parser",
       "kind" : "remoteSourceControl",
-      "location" : "https://github.com/apple/swift-argument-parser.git",
+      "location" : "https://github.com/apple/swift-argument-parser",
       "state" : {
         "revision" : "46989693916f56d1186bd59ac15124caef896560",
         "version" : "1.3.1"

diff --git a/DuckDuckGo/RemoteMessaging.swift b/DuckDuckGo/RemoteMessaging.swift
@@ -181,6 +181,7 @@ struct RemoteMessaging {
                                                            isWidgetInstalled: isWidgetInstalled,
                                                            isNetPWaitlistUser: isNetworkProtectionWaitlistUser,
                                                            daysSinceNetPEnabled: daysSinceNetworkProtectionEnabled),
+                percentileStore: RemoteMessagingPercentileUserDefaultsStore(userDefaults: .standard),
                 dismissedMessageIds: remoteMessagingStore.fetchDismissedRemoteMessageIds()
             )
 

diff --git a/DuckDuckGoTests/RemoteMessagingStoreTests.swift b/DuckDuckGoTests/RemoteMessagingStoreTests.swift
@@ -27,17 +27,21 @@ import CoreData
 
 class RemoteMessagingStoreTests: XCTestCase {
 
-    private var data = JsonTestDataLoader()
+    static let userDefaultsSuiteName = "remote-messaging-store-tests"
 
+    private var data = JsonTestDataLoader()
     private var store: RemoteMessagingStore!
-
     private let notificationCenter = NotificationCenter()
+    private var defaults: UserDefaults!
 
     override func setUpWithError() throws {
         try super.setUpWithError()
         let container = CoreData.remoteMessagingContainer()
         let context = container.viewContext
         store = RemoteMessagingStore(context: context, notificationCenter: notificationCenter)
+
+        defaults = UserDefaults(suiteName: Self.userDefaultsSuiteName)!
+        defaults.removePersistentDomain(forName: Self.userDefaultsSuiteName)
     }
 
     override func tearDownWithError() throws {
@@ -139,6 +143,7 @@ class RemoteMessagingStoreTests: XCTestCase {
                                                            isWidgetInstalled: false,
                                                            isNetPWaitlistUser: false,
                                                            daysSinceNetPEnabled: -1),
+                percentileStore: RemoteMessagingPercentileUserDefaultsStore(userDefaults: self.defaults),
                 dismissedMessageIds: []
         )