-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Serial Config message and more protocol #17
Conversation
# | ||
# This message carries baudrate for tunnel channel_id | ||
|
||
uint8 channel_id |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure how this works or what this means. Some description might be helpful.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It comes from other data carrying messages, I will add info here as well.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's still not clear to me what this means or how it works, but I'm probably missing UAVCAN context.
2295d9a
to
8e7aa83
Compare
8e7aa83
to
2a2c764
Compare
|
||
uint32 baud | ||
|
||
uint32 options |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How are the options encoded? Or would this be additional enums?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
additional enums will be required, I am letting them not defined until there is actual implementation.
# | ||
# This message carries baudrate for tunnel channel_id | ||
|
||
uint8 channel_id |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's still not clear to me what this means or how it works, but I'm probably missing UAVCAN context.
2a2c764
to
6d1f636
Compare
this is already merged |
No description provided.