Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Serial Config message and more protocol #17

Closed

Conversation

bugobliterator
Copy link
Collaborator

No description provided.

uavcan/tunnel/Protocol.uavcan Outdated Show resolved Hide resolved
#
# This message carries baudrate for tunnel channel_id

uint8 channel_id

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure how this works or what this means. Some description might be helpful.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It comes from other data carrying messages, I will add info here as well.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's still not clear to me what this means or how it works, but I'm probably missing UAVCAN context.


uint32 baud

uint32 options

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How are the options encoded? Or would this be additional enums?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

additional enums will be required, I am letting them not defined until there is actual implementation.

uavcan/tunnel/Protocol.uavcan Outdated Show resolved Hide resolved
#
# This message carries baudrate for tunnel channel_id

uint8 channel_id

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's still not clear to me what this means or how it works, but I'm probably missing UAVCAN context.

uavcan/tunnel/2011.SerialConfig.uavcan Outdated Show resolved Hide resolved
@tridge
Copy link
Member

tridge commented Dec 12, 2022

this is already merged

@tridge tridge closed this Dec 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants